Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change filters via 'Show filters' #24994

Closed
maxzheng opened this issue Aug 24, 2022 · 1 comment · Fixed by #25228
Closed

Can't change filters via 'Show filters' #24994

maxzheng opened this issue Aug 24, 2022 · 1 comment · Fixed by #25228
Assignees
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@maxzheng
Copy link
Contributor

Describe the bug

In a saved question, when I clicked on "Show filters" and try to change any of the filters (date, is empty, etc), the Update filter button grays out immediately.

Logs
None

To Reproduce
Steps to reproduce the behavior:

  1. Go to any saved question with filters
  2. Click on "Show filters"
  3. Try to change any filter's value (is empty to not empty, date to another date, etc)
  4. Update filter button grays out immediately

Expected behavior
Update filter button shouldn't gray out, so the new filter can be applied.

Screenshots

n/a as it's pretty simple / screenshot won't provide much value

Information about your Metabase Installation:

You can get this information by going to Admin -> Troubleshooting.

  • Your browser and the version: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36",

  • Your operating system: MacIntel

  • Your databases: Redshift

  • Metabase version: master / 1fca705

  • Metabase hosting environment: Metabase Cloud

  • Metabase internal database: Postgres

Severity
How severe an issue is this bug to you? Is this annoying, blocking some users, blocking an upgrade or blocking your usage of Metabase entirely?
It's a bit inconvenient as I need to go to the question's editor page to make changes instead.

Additional context
None

@maxzheng maxzheng added Type:Bug Product defects .Needs Triage labels Aug 24, 2022
@flamber
Copy link
Contributor

flamber commented Aug 25, 2022

Regression since 0.44.0 - related to #11957/#14193/#15620

Workaround: It is possible to change the filter via the filter modal or Notebook editor.

Reproduce:

  1. Question > Sample > Products
  2. Filter Category=(select all) and CreatedAt=past 30 years
  3. Count grouped by Category
  4. Filter Count > 0
    image
  5. Try making any changes to the Category or CreatedAt filter pills - it will disable the "Update filter" button
    image

@flamber flamber added Priority:P2 Average run of the mill bug Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Frontend Querying/GUI Query builder catch-all, including simple mode .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. and removed .Needs Triage labels Aug 25, 2022
@akiselev akiselev self-assigned this Aug 29, 2022
nemanjaglumac added a commit that referenced this issue Aug 29, 2022
ranquild pushed a commit that referenced this issue Sep 5, 2022
@ranquild ranquild added the .Reproduced Issues reproduced in test (usually Cypress) label Sep 5, 2022
@ranquild ranquild self-assigned this Sep 5, 2022
@ranquild ranquild added this to the 0.44.3 milestone Sep 5, 2022
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
4 participants