Switch from Nashorn to GraalVM JS engine; support Java 15+ #15708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15708 +/- ##
==========================================
- Coverage 84.42% 84.40% -0.02%
==========================================
Files 401 402 +1
Lines 31299 31307 +8
Branches 2259 2260 +1
==========================================
+ Hits 26424 26426 +2
- Misses 2616 2621 +5
- Partials 2259 2260 +1
Continue to review full report at Codecov.
|
6b44c57
to
ed5e856
Compare
|
I had no idea that the js engine from graal was able to be used from other jdks. That is awesome. |
dpsutton
approved these changes
Apr 21, 2021
This was referenced Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out we can use the GraalVM JavaScript engine for our JavaScript execution needs, allowing us to finally remove our Nashorn dep and support Java 15 and 16.
I added tests against Java 16 (current latest) to CI and added Java 8 back which was accidentally changed in #15201.
Fixes #13881
Fixes #15707