More question details in sidebar #47705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89ffe8b
to
75b5ec8
Compare
9ee9f29
to
788ac6d
Compare
de85597
to
d4f0c0b
Compare
788ac6d
to
f06000c
Compare
Base automatically changed from
side-sheets/question-settings-sidebar
to
side-sheets/question-info-sidebar
September 6, 2024 21:57
f06000c
to
2e3471d
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e3c94e4...384b2a6.
|
An error occurred while trying to automatically change base from
side-sheets/question-info-sidebar
to
master
September 9, 2024 18:24
a07e8a8
to
06212e1
Compare
iethree
commented
Sep 9, 2024
There was a problem hiding this comment.
I tried to do some fancy new things with this component, and then realized I should not do that, but it ended up in typescript, which was a win.
iethree
commented
Sep 9, 2024
| function formatDateTimeWithFormats( | ||
| value: number | Moment, | ||
| export function formatDateTimeWithFormats( | ||
| value: number | string | Date | Moment, |
There was a problem hiding this comment.
this is all a consequence of converting the DateTime component to typescript
iethree
commented
Sep 9, 2024
There was a problem hiding this comment.
this is mostly stolen from @rafpaf, but made reusable for both questions and dashboards
small styling updates refine styling to match designs update more e2e test remove some changes small styling updates more question details more question details DateTime to typescript test updates type updates export fix fixes
06212e1
to
c92b0de
Compare
vbenedetti
approved these changes
Sep 11, 2024
rafpaf
reviewed
Sep 12, 2024
.../src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/QuestionDetails.tsx
Outdated
Show resolved
Hide resolved
rafpaf
reviewed
Sep 12, 2024
.../src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/QuestionDetails.tsx
Outdated
Show resolved
Hide resolved
rafpaf
reviewed
Sep 12, 2024
.../src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/QuestionDetails.tsx
Show resolved
Hide resolved
rafpaf
reviewed
Sep 12, 2024
.../src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/QuestionDetails.tsx
Show resolved
Hide resolved
rafpaf
reviewed
Sep 12, 2024
.../src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar/QuestionDetails.tsx
Outdated
Show resolved
Hide resolved
rafpaf
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47673
Description
Adds more detailed information to Question Info sidesheets:
Checklist