Convert ChartType components to Mantine
#47745
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r' into split-files-in-chart-type-sidebar
oisincoveney
commented
Sep 6, 2024
There was a problem hiding this comment.
After playing around with this type, I've noticed that we don't use it, and it produces some very sketchy looking buttons. We're better off using the default filled variant and specifying a color.
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 44806ac...e3ac4ac.
|
alxnddr
reviewed
Sep 10, 2024
| import { ChartTypeOption, type ChartTypeOptionProps } from "../ChartTypeOption"; | ||
|
|
||
| export type ChartTypeListProps = { | ||
| visualizationList: ChartTypeOptionProps["visualizationType"][]; |
There was a problem hiding this comment.
nit: using just underlying types like CardDisplayType here would be a bit more readable
| }; | ||
|
|
||
| describe("ChartTypeOption", () => { | ||
| Object.entries(EXPECTED_VISUALIZATION_VALUES).forEach( |
There was a problem hiding this comment.
EXPECTED_VISUALIZATION_VALUES is an object where key is also in the value. Wdyt about making it an array, and then using it.each(EXPECTED_VISUALIZATION_VALUES)? It would help to remove type casts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the
ChartTypecomponents to Mantine. This will help us with theming and customization within the Embedding SDK, and also just gives us a few more Mantine components to work with 😄