cleanup data reference tooltips #47747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iethree
commented
Sep 6, 2024
| @@ -30,9 +31,7 @@ const ListItem = ({ | |||
| </div> | |||
| <div className={S.itemBody}> | |||
| <div className={S.itemTitle}> | |||
| <ListItemName tooltip={name} tooltipMaxWidth="100%"> | |||
There was a problem hiding this comment.
tooltipMaxWidth here was the biggest sin. I think with our old tooltip, this was based on the width of the container, and our new tooltips get appended to the body so the container is the screen width.
iethree
commented
Sep 6, 2024
| <ListItemName tooltip={name} tooltipMaxWidth="100%"> | ||
| <h3>{name}</h3> | ||
| </ListItemName> | ||
| <Ellipsified tooltip={name}>{name}</Ellipsified> |
There was a problem hiding this comment.
I killed this styled component because it just made it all harder to reason about
iethree
commented
Sep 6, 2024
| @@ -30,9 +31,7 @@ const ListItem = ({ | |||
| </div> | |||
| <div className={S.itemBody}> | |||
| <div className={S.itemTitle}> | |||
| <ListItemName tooltip={name} tooltipMaxWidth="100%"> | |||
| <h3>{name}</h3> | |||
There was a problem hiding this comment.
nesting a component inside ellipsified prevented anything from actually getting an ellipsis
rafpaf
approved these changes
Sep 12, 2024
iethree
added a commit
that referenced
this pull request
Sep 12, 2024
* cleanup data reference tooltips * update test # Conflicts: # frontend/src/metabase/components/ListItem/ListItem.styled.tsx
iethree
added a commit
that referenced
this pull request
Sep 12, 2024
* cleanup data reference tooltips * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discussion
Description
Before
Some short things get enormous tooltips
Some long things don't get tooltips or ellipses at all
After
Tooltips are a normal size, and long names get ellipsified properly
There are still some cases where tooltips show up unnecessarily, but I didn't want to waste any more time on that.