Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add capability to store session data locally and button to send the data to slack #47772

Closed
wants to merge 4 commits into from

Conversation

filiphric
Copy link
Contributor

@filiphric filiphric commented Sep 9, 2024

Description

This adds the functionality to record sessions in Metabase. Before releasing, we need to make sure this is enabled only on status.metabase.com and local development.

tl;dr of the feature:

  • when user opens metabase, rrweb package starts recording events to browser’s indexed database
  • clicking on a button "download bug report data" will collect the database information, save it to json file and download it
  • this will be changed, we’ll be sending that to slack instead ✅
  • we also collect network information to this database (rrweb does not collect it, although there seems to be a plugin in development for it) ✅
  • no console legs yet, but will be added
  • build information and debug information will be added as well
  • data collected can be viewed and debugged using "metabase-debugger" which you can clone and run locally (we may add deployment too ✅ found here)

things to consider:

  • compressing data
  • placement of the rrweb script
  • how to handle the fact we want to load this only on certain domains
  • how can we make this play nice with debugging data we already have e.g. in the admin section

UPDATE 16th Sep 2024:

  • the recording capability is now working
  • setting a MS_INTERNAL_BUILD flag to true will enable the session recording
  • bug reports are sent to #bug-reports-internal slack channel
  • right now, json files can be downloaded from the slack channel and debugged on the debugger app
  • in order for the recorder to be able to send the data, MB_SLACK_BOT_TOKEN needs to be set up
  • currently, there is no build that would enable this anywhere. in order to make this into production (stats.metabase.com) we need to create a separate build with MB_INTERNAL_BUILD flag set to true

@filiphric filiphric added the backport Automatically create PR on current release branch on merge label Sep 16, 2024
@filiphric filiphric marked this pull request as ready for review September 16, 2024 11:52
Copy link
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 1174d9c...637f959.

Notify File(s)
@kdoh frontend/src/metabase/ui/components/icons/Icon/icons/bug.svg
frontend/src/metabase/ui/components/icons/Icon/icons/index.ts

@filiphric filiphric changed the title add capability to store session data locally and button to download them add capability to store session data locally and button to send the data to slack Sep 16, 2024
@iethree
Copy link
Contributor

iethree commented Sep 26, 2024

Closing in favor of browser extension approach 👍

@iethree iethree closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants