Fix pie rows settings include filtered out values #47879
Merged
+87
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmadUsmani
reviewed
Sep 12, 2024
There was a problem hiding this comment.
The problem with this approach is that when you edit pie.rows and save the question after rows have been removed from the query result, when those rows reappear they will no longer have their settings. This is why we kept track of the removed rows and marked them with hidden: true instead of removing them from the setting. See the example below
Screen.Recording.2024-09-11.at.5.00.13.PM.mov
ee09f58
to
fb8dad3
Compare
|
@EmmadUsmani thanks, I fixed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47867
Description
After editing pie rows settings, if dataset returned fewer rows we still showed previously existing rows in the settings sidebar. This PR filters them out.
How to verify
Checklist