[WIP] Use type date for case expression when there are Date and DateTime args #47902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c7e06e
to
ac675d0
Compare
ranquild
approved these changes
Sep 13, 2024
metamben
reviewed
Sep 13, 2024
There was a problem hiding this comment.
To me, this means that we are saying that all operations that are valid for :type/Date are valid for a case expression containing a :type/DateTime value. If that's true, then :type/Date should be an ancestor of :type/DateTime, and this hack is not needed. If that's not true, then this invites trouble.
I have the feeling we are expecting too much from a single type hierarchy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47887
Description
The issue is that we infer return type for
caseexpression as most specific common ancestor. If the arguments are:type/Dateand:type/DateTimethe ancestor is:type/Temporal. That results in limited filter picker options.This PR adds special case for arguments of aforemementioned types. The
:type/Dateis picked as the expression type.The question is however, whether the current behavior is really erroneous. To the best of my knowledge there's no way to decide correct argument type in this case, and picking the
:type/Dateis best effort, that could enable some cases, but may result in error in others.Following stack (in reverse) is significant for the context (ie. if you are interested in how I got to this specific change):
How to verify
Describe the steps to verify that the changes are working as expected.
Demo
Upload a demo video or before/after screenshots if sensible or remove the section
Checklist