bypass race condition to avoid flakiness in click behaviour test #47917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uladzimirdev
commented
Sep 16, 2024
|
|
||
| // this is done to bypass race condition problem, the root cause for it is | ||
| // described in `updateDashboardAndCards` from frontend/src/metabase/dashboard/actions/save.js | ||
| visitDashboard("@dashboardId"); |
There was a problem hiding this comment.
this is the main change, old code didn't contain that visitDashboard
regular cy.wait(5000) worked too in my tests, but this wait I like more
ranquild
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a workaround to bypass race condition that appears on slow networks during saving the dashboard
✅ stress 30/30