Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sunburst to pie chart #47208

Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open

add sunburst to pie chart #47208

wants to merge 51 commits into from

Conversation

EmmadUsmani
Copy link
Contributor

@EmmadUsmani EmmadUsmani commented Aug 25, 2024 •
edited
Loading

Closes #47209

Description

Describe the overall approach and the problem being solved.

How to verify

Describe the steps to verify that the changes are working as expected.

  1. New question -> Sample Dataset -> ...
  2. ...

Demo

Upload a demo video or before/after screenshots if sensible or remove the section

Checklist

  • Tests have been added/updated to cover changes in this PR

@EmmadUsmani EmmadUsmani marked this pull request as ready for review August 25, 2024 21:29
This was referenced Aug 25, 2024
Merged
Merged
@EmmadUsmani Graphite App
Copy link
Contributor Author

EmmadUsmani commented Aug 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EmmadUsmani and the rest of your teammates on Graphite Graphite

@EmmadUsmani EmmadUsmani mentioned this pull request Aug 25, 2024
Merged
1 task
@metabase-bot metabase-bot bot added the .Team/DashViz Dashboard and Viz team label Aug 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 25, 2024 •
edited
Loading

Codenotify: Notifying subscribers in CODENOTIFY files for diff 05c2fb2...85a6bd7.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/components/ChartTooltip/EChartsTooltip/EChartsTooltip.tsx
frontend/src/metabase/visualizations/echarts/pie/constants.ts
frontend/src/metabase/visualizations/echarts/pie/format.ts
frontend/src/metabase/visualizations/echarts/pie/model/index.ts
frontend/src/metabase/visualizations/echarts/pie/model/types.ts
frontend/src/metabase/visualizations/echarts/pie/option.ts
frontend/src/metabase/visualizations/echarts/pie/tooltip.tsx
frontend/src/metabase/visualizations/echarts/pie/types.ts
frontend/src/metabase/visualizations/echarts/pie/util.ts
frontend/src/metabase/visualizations/echarts/tooltip/index.tsx
frontend/src/metabase/visualizations/shared/settings/pie.ts
frontend/src/metabase/visualizations/types/hover.ts
frontend/src/metabase/visualizations/visualizations/PieChart/PieChart.tsx
frontend/src/metabase/visualizations/visualizations/PieChart/chart-definition.ts
frontend/src/metabase/visualizations/visualizations/PieChart/use-chart-events.ts

@EmmadUsmani EmmadUsmani mentioned this pull request Aug 26, 2024
Open
40 tasks
@EmmadUsmani EmmadUsmani added the no-backport Do not backport this PR to any branch label Aug 26, 2024 — with Graphite App
@EmmadUsmani EmmadUsmani force-pushed the add-sunburst-to-pie-chart branch 3 times, most recently from 2975803 to ba41e36 Compare August 26, 2024 17:36
@EmmadUsmani EmmadUsmani force-pushed the allow-re-ordering-and-re-naming-pie-chart-slices branch from f939832 to 580040d Compare August 26, 2024 17:54
@EmmadUsmani EmmadUsmani force-pushed the add-sunburst-to-pie-chart branch 6 times, most recently from 636e4a7 to c96508b Compare August 29, 2024 00:58
Base automatically changed from allow-re-ordering-and-re-naming-pie-chart-slices to master August 29, 2024 15:57
@EmmadUsmani
fix missing tooltip colors for middle and outer rings
e7ff762
@EmmadUsmani
fix legend not appearing
ce12b71
@EmmadUsmani
update font size
de0f9fb
@EmmadUsmani
stub component for viz settings
5ba8da5
@EmmadUsmani
add dimensinon pickers to settings sidebar
7db7e91
@EmmadUsmani
dont allow user to remove inner ring
c42663d
@EmmadUsmani
readd pie.rows setting component
8edf833
@EmmadUsmani
add dnd kit components
3825c76
@EmmadUsmani
reorder dimensions after dnd
5d4a99b
@EmmadUsmani
disable pie.rows dragging when reordering dimensions
6625687
@EmmadUsmani
render drag overlay
b47e599
@EmmadUsmani
remove canReorder prop
cb2d439
@EmmadUsmani
fix props on drag overlay component
dcd44c1
@EmmadUsmani
default settings computations
289e4d7
@EmmadUsmani
remove direct usages of pie.middle_dimension and pie.outer_dimension
ade1ff9
@EmmadUsmani
replace pie.middle_dimension and pie.outer_dimension with array in pi…
9adab3f 
…e.dimension
@EmmadUsmani
update DimensionsWidget to match new setting
8ec4f3c
@EmmadUsmani
add stories and snapshots
fc423b1
@EmmadUsmani
add e2e test for column mapping
32c4931
@EmmadUsmani
add e2e test for editing rings
95a31a4
@EmmadUsmani
add e2e test for hover and click
b631f8e
@EmmadUsmani
update isSensible
a679ee9
@EmmadUsmani
update e2e specs
0c18932
@EmmadUsmani
don't show add ring button if there are no available columns
f9bcae4
@EmmadUsmani
don't allow dragging single ring
87da0e2
@EmmadUsmani
fix lable not appearing on other slice
09ebaa5
@EmmadUsmani
only show single row in color picker when there are multiple rings
e1dafb8
@EmmadUsmani
change slice key type to string
7ec15f0
@EmmadUsmani
fix other slice hover bug
49192df
@EmmadUsmani
use pieLegendHoverIndex instead of hovered.index
b4e959a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@EmmadUsmani EmmadUsmani

Labels
no-backport Do not backport this PR to any branch .Team/DashViz Dashboard and Viz team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Epic] Multi-dimensional / Sunburst Pie chart
1 participant
@EmmadUsmani