enhancement: add new record_many method for histograms
#531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
record_many method for histograms
|
But it still inefficiently burns CPU cycles:( |
|
Yep, there's still work to do in order to actually have storage implementations provide an optimized implementation for it. If you're interested in contributing a PR to add that support for |
|
Released as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We've added a new method for recording to histograms:
record_many. This is exposed on bothHistogramandHistogramFn, with a default implementation provided onHistogramFnto make it backwards compatible.It allows recording a single value multiple times, which can be a common use case when translating from bucketed histograms to histograms in
metrics, as bucketed histograms may simply provide a single value for a bucket and the count of that value... so representing such a bucket inmetricsrequires recording that valuecounttimes.Closes #509.