Skip to content

fix: add proper spacing to add-document-button #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2024
Merged

fix: add proper spacing to add-document-button #754

merged 2 commits into from
Oct 12, 2024

Conversation

souvikjs01
Copy link
Contributor

fixes #752
This PR addresses the inconsistent spacing on the https://app.papermark.io/documents on mobile view. Adjustments have been made to ensure a more uniform and visually appealing layout.

Screenshot 2024-10-11 161833

Screenshot 2024-10-11 170423

@souvikjs01 souvikjs01 requested a review from mfts as a code owner October 11, 2024 12:11
@vercel Vercel
Copy link

vercel bot commented Oct 11, 2024

@souvikjs01 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@souvikjs01 souvikjs01 changed the title fixed: make proper spacing #752 fixed: make proper spacing Oct 11, 2024
mfts
mfts requested changes Oct 11, 2024
View reviewed changes
Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@souvikjs01 what would be really good is, if the button text would not wrap but instead fit so that's only one line instead of two.

could you make that happen without changing the text content?

@souvikjs01
Copy link
Contributor Author

souvikjs01 commented Oct 11, 2024 •
edited
Loading

@souvikjs01 what would be really good is, if the button text would not wrap but instead fit so that's only one line instead of two.

could you make that happen without changing the text content?

Sure i'm working on it.

Screenshot 2024-10-11 235614

mfts
mfts approved these changes Oct 12, 2024
View reviewed changes
Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mfts
Copy link
Owner

mfts commented Oct 12, 2024

@souvikjs01 please sign the CLA as indicated above

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

@souvikjs01
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@vercel Vercel
Copy link

vercel bot commented Oct 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 10:43am

@mfts mfts changed the title fixed: make proper spacing fix: make proper spacing Oct 12, 2024
@mfts mfts changed the title fix: make proper spacing fix: add proper spacing to add-document-button Oct 12, 2024
@mfts mfts merged commit 8f6db4e into mfts:main Oct 12, 2024
3 checks passed
@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 12, 2024

Awarding souvikjs01: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/souvikjs01

@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
@souvikjs01 souvikjs01 deleted the proper-allign-item branch October 12, 2024 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mfts mfts mfts approved these changes

Assignees
No one assigned
Labels
hacktoberfest 🕹️ 150 points 🕹️ oss.gg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🕹️] Inconsistent spacing and irresponsive button content
2 participants
@souvikjs01 @mfts