Two possible fixes ms Length varies, Timezone difference in string #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23
Using data obtained from a web service I found that the length of the number of milliseconds varied from 1 to 3 characters, this caused a out of bounds exception in CreateInteger() called by CreateDate which was assuming the millisecond length was 3. The fix I have in place only accounts for Z or no Z in the datetime string, it doesn't (yet) account for +-HH:MM listed in ISO 8601
#11
When using dotnet 4 (or greater) using:
DateTime.Parse(value, null, System.Globalization.DateTimeStyles.RoundtripKind);
performs slightly faster and handles more situations than the previous code.