Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dragging to select in the debug console to scroll as the top and bottom edges are reached. #228432

Closed
rehmsen opened this issue Sep 13, 2024 · 0 comments · Fixed by #236534
Closed

Support dragging to select in the debug console to scroll as the top and bottom edges are reached. #228432

rehmsen opened this issue Sep 13, 2024 · 0 comments · Fixed by #236534
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
January 2025

Comments

@rehmsen
Copy link
Contributor

rehmsen commented Sep 13, 2024

When selecting something in a scrolling container, dragging to the edges of the container should start scrolling. For VS Code Terminal is one example of a container where this works. The VS Code debug console does not support this: It starts selecting lines of the editor which happens to be above the debug console.
@rebornix rebornix assigned connor4312 and unassigned roblourens Dec 16, 2024
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Dec 16, 2024
connor4312 added a commit that referenced this issue Dec 18, 2024
@connor4312
lists: support user selection in lists, and adopt it in the debug con…
d04d6f4 
…sole

- Adds a `userSelection` option on lists that can be used to control behavior
- Uses the DND logic for handling scrolling near the top and bottom
- Preserved selected list elements while they're selected to ensure they
  can be accurately copied.
- The DOM events we get around selection are pretty poor. I support mouse
  here but I'm unclear if/how touch events should be handled.

![](https://memes.peet.io/img/24-12-f06c680d-f209-476b-8945-b6fc33efe502.mp4)

Fixes #228432, cc @joaomoreno
@connor4312 connor4312 mentioned this issue Dec 18, 2024
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 19, 2024
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Dec 19, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 19, 2024
@lszomoru lszomoru added the verified Verification succeeded label Jan 30, 2025
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

lists: support user selection in lists, and adopt it in the debug console microsoft/vscode
4 participants
@rehmsen @roblourens @connor4312 @lszomoru