Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single tab context menu actions sometimes don't work #201021

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix single tab context menu actions sometimes don't work #201021

merged 1 commit into from
Dec 15, 2023

Conversation

jeanp413
Copy link
Contributor

Fixes #201008

@jeanp413 jeanp413 mentioned this pull request Dec 15, 2023
Closed
@Tyriar Tyriar added this to the December / January 2024 milestone Dec 15, 2023
@meganrogge
Copy link
Contributor

@jeanp413 thanks so much for looking into this. In OSS, with your changes, I'm still seeing the issue.

@jeanp413
Copy link
Contributor Author

jeanp413 commented Dec 15, 2023 •
edited
Loading

@meganrogge Did you happen to test with rename? just realized that it has been broken for a while not related to #199228 (will look into it) , but change color/icon works for me 🤔

@meganrogge
Copy link
Contributor

You are correct, the issue with rename reproduces in stable. I'll make a separate issue for that.

meganrogge
meganrogge approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@meganrogge meganrogge merged commit 6248d9b into microsoft:main Dec 15, 2023
6 checks passed
@jeanp413 jeanp413 deleted the fix-201008 branch December 15, 2023 22:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreamah andreamah andreamah approved these changes

@meganrogge meganrogge meganrogge approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

single tab context menu actions sometimes don't work
4 participants
@jeanp413 @meganrogge @andreamah @Tyriar