Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make regular text in markdown comments wrap in notebook editors. #224484

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

rehmsen
Copy link
Contributor

@rehmsen rehmsen commented Aug 1, 2024

Fixes #224483.

Without this, the comments inherit nowrap from monaco-list. I decided to fix it at this level because only in the notebook editor the comments seem to be ancestors of a monaco-list. I picked "initial" to indicate we are not actively trying to set anything, we are just trying to go back to normal, as the markdown renderer expects it.

Fixes microsoft#224483.

Without this, the comments inherit nowrap from monaco-list. I decided to fix it at this level because only in the notebook editor the comments seem to be ancestors of a monaco-list. I picked "initial" to indicate we are not actively trying to set anything, we are just trying to go back to normal, as the markdown renderer expects it.
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rebornix rebornix added this to the August 2024 milestone Aug 15, 2024
@rebornix rebornix closed this Aug 26, 2024
@rebornix rebornix reopened this Aug 26, 2024
@rebornix rebornix merged commit c06299a into microsoft:main Aug 26, 2024
9 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebook markdown comments should wrap long sentences
5 participants