Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bot trigger for contribution thread #28221

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

Aaron-Junker
Copy link
Collaborator

@Aaron-Junker Aaron-Junker commented Aug 30, 2023

Summary of the Pull Request

Added bot trigger command and adjusted contributing.md

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected

@Aaron-Junker Aaron-Junker marked this pull request as draft August 30, 2023 16:35
Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Jay-o-Way
Copy link
Collaborator

Hi! What is a contributing thread?

@htcfreek
Copy link
Collaborator

Hi! What is a contributing thread?

If someone says "I like to fix this".

@Aaron-Junker
Copy link
Collaborator Author

Hi! What is a contributing thread?

If someone says "I like to fix this".

Exactly.

@crutkas
Copy link
Member

crutkas commented Sep 26, 2023

#28769

@Aaron-Junker Aaron-Junker marked this pull request as ready for review September 26, 2023 11:21
@htcfreek
Copy link
Collaborator

htcfreek commented Oct 7, 2023

Do we have a default answer for accepting a contribution request?

@crutkas
Copy link
Member

crutkas commented Oct 11, 2023

This ready?

@Aaron-Junker
Copy link
Collaborator Author

This ready?

Yes.

@Aaron-Junker
Copy link
Collaborator Author

@crutkas Is something holding this back from getting merged?

@crutkas
Copy link
Member

crutkas commented Nov 15, 2023

was waiting for you to check it in :)

@crutkas crutkas merged commit 1f4eff4 into main Nov 15, 2023
12 checks passed
@crutkas crutkas deleted the dev/aaron-junker/add-contributing-commands branch November 15, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants