Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotation mark #30481

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Quotation mark #30481

wants to merge 11 commits into from

Conversation

warquys
Copy link

@warquys warquys commented Dec 16, 2023 •
edited
Loading

Add Quotation mark

Add local quotation based on VK_OEM_7(0xDE) key.
Not all quotes have been added, only ‟ „ ” « » ‚ , ‘ ’ › ‹ '「 」 《 》 『 』〈 〉
Why not added :

  • ⹂ ⌜ ⌝ ❛ ❜ ❝ ❞ 🙶 🙷 🙸 ＇ ｢ ｣ its redundant and would make too much and not readable.
  • ﹁ ﹂ ﹃ ﹄ I did not put them because there use for horizontal text

PR Checklist

This PR is currently a draft, I still need to know if adding language-related keyboard management is a good idea or specifying the use of a gobal key to make it easier to manage all the keyboards in one. Some languages ​​can use different keyboards, I think this would become problematic if the keyboard does not match the key used by default. However, using a universal key can also pose an issue to finding the key. that remains to be discussed

Validation Steps Performed

@warquys warquys marked this pull request as ready for review December 16, 2023 04:22
@warquys warquys marked this pull request as draft December 16, 2023 04:25
@Jay-o-Way Jay-o-Way added the Product-Quick Accent Refers to the Quick Accent PowerToy label Dec 16, 2023
@PesBandi PesBandi mentioned this pull request Dec 17, 2023
Closed
@warquys
Copy link
Author

warquys commented Dec 21, 2023

@microsoft-github-policy-service agree

@warquys warquys marked this pull request as ready for review February 29, 2024 20:45
jaimecbernardo
jaimecbernardo requested changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR. I've tried to test it, but it looks like VK_OEM_7 is not present in my keyboard. These look like they'll only be available in some keyboards, depending on language. Would it make sense to add it to a different key that's more prevalent? Wonder if . makes sense, but I'm open to other ideas as well.

@jaimecbernardo
Copy link
Collaborator

Perhaps the comma key, since it sort of looks like a quote? 🤷

@warquys
Copy link
Author

warquys commented Mar 13, 2024

I think . is better because , is curenlty use for mathematical simbol from Portuguese.
If i add it to , it will be to much.

@Jay-o-Way
Copy link
Collaborator

Hi. Is this pr ready?

@warquys
Copy link
Author

warquys commented Jun 4, 2024 •
edited
Loading

yes, i test it a last time.
If you're not reading this message do not pusj it yet, I would like to send you a screen shot to show you what it looks like. Maybe it's too much on one key.

@warquys
Copy link
Author

warquys commented Jun 4, 2024

image
For me there is to much on a same key.
I've also noticed that the slide bar can't be used

@warquys
Copy link
Author

warquys commented Jun 8, 2024

I suggest roll back the commit and use VK_QUOT_

@warquys
Copy link
Author

warquys commented Jun 20, 2024 •
edited
Loading

Maybe move the mathematics symbols will be a better options. But i do not now on what key to put theme and if you are ok with this.

I put the pull request back into draft. Because even if technically the code works, I am clearly not satisfied with the result.

@warquys warquys marked this pull request as draft June 20, 2024 04:07
@warquys
Copy link
Author

warquys commented Jun 29, 2024

To give a little feedback. I'm thinking of working on character display. It seems that when there are too many characters, the display go out of screen.
This seems to be linked to the use of the window being floating and the use of VirtualizingStackPanel. VirtualizingStackPanel wants to take up as much space as possible. leading to an overflow out of the screen.

  • I don't know if opening another pull request would be a solution, or adding it to the one if it's suitable.
  • I don't know yet how to fix this bug, I need to document on it.
  • Maybe I should i open an issue?

Sorry it's taking so long for this pool request

@warquys warquys marked this pull request as ready for review June 30, 2024 19:50
@warquys
Copy link
Author

warquys commented Jul 3, 2024 •
edited
Loading

I consider having finished, but I would like a last review.

I want to point out that the display (when put on all the languages) go still outisde the screen.

Sorry, i just find out if you put the display postion of the disspaly Right you get an issue.

I added focus on the curent char via `ScrollIntoView' when the user changes the active char.

@warquys warquys closed this Jul 3, 2024
@warquys warquys reopened this Jul 3, 2024
@warquys
Copy link
Author

warquys commented Jul 3, 2024 •
edited
Loading

Miss click.

I defined the maximum width that the window could have.
This seems complete to me, I tested it on various resolutions. However, I would still like you to test it.

@warquys
Copy link
Author

warquys commented Oct 9, 2024

@Jay-o-Way The pr is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo Awaiting requested review from jaimecbernardo

@crutkas crutkas Awaiting requested review from crutkas

@ethanfangg ethanfangg Awaiting requested review from ethanfangg

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Product-Quick Accent Refers to the Quick Accent PowerToy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@warquys @jaimecbernardo @Jay-o-Way