Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data diagnostics opt-in #34078

Merged
merged 44 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
bea3607
Data diagnostics opt-in
stefansjfw Sep 24, 2024
96503cf
[c++] Drop DROP_PII flag
stefansjfw Oct 11, 2024
751c05a
Bump telemtry package to 2.0.2
stefansjfw Oct 11, 2024
13854d4
Merge remote-tracking branch 'origin/main' into stefan/opt_in_telem
stefansjfw Oct 11, 2024
f0d5387
Drop DropPii from custom actions
stefansjfw Oct 11, 2024
d662b58
Cleanup
stefansjfw Oct 11, 2024
b1f260e
Merge remote-tracking branch 'origin/main' into stefan/opt_in_telem
stefansjfw Oct 14, 2024
9f00966
Do not start manually C# EtwTrace. FZ engine exit event.
stefansjfw Oct 14, 2024
d8ad216
ImageResizer, PowerRename, FileLocksmith prev handlers
stefansjfw Oct 14, 2024
4c75a39
Revert C# handlers exe logging
stefansjfw Oct 14, 2024
4e4b5f4
Revert "Revert C# handlers exe logging"
stefansjfw Oct 15, 2024
16a27e8
Do not recreate EtwTrace
stefansjfw Oct 15, 2024
ed2b785
Merge remote-tracking branch 'origin/main' into stefan/opt_in_telem
stefansjfw Oct 15, 2024
07eb84a
consume package
stefansjfw Oct 15, 2024
cad1d76
xaml formatting
stefansjfw Oct 15, 2024
cdf85dd
Fix deps.json audit
stefansjfw Oct 15, 2024
3f96a92
Update telem package paths
stefansjfw Oct 16, 2024
d3139db
Address PR comments
stefansjfw Oct 16, 2024
5452ca4
Fix AdvancedPaste close on PT close
stefansjfw Oct 17, 2024
efaed02
Override etl file name for explorer loaded dlls
stefansjfw Oct 17, 2024
d340aed
Fix setting desc
stefansjfw Oct 17, 2024
b114543
Fix missing events
stefansjfw Oct 17, 2024
ac02d50
Add infobar to restart when enable data viewing
stefansjfw Oct 17, 2024
5d672ea
Flush on timer every 30s
stefansjfw Oct 18, 2024
2cdc6e1
Merge remote-tracking branch 'origin/main' into stefan/opt_in_telem
stefansjfw Oct 18, 2024
1e44463
[Settings] Update View Data diagnostic description text
stefansjfw Oct 21, 2024
d1d155d
Show Restart info bar for both enable/disable data viewer
stefansjfw Oct 21, 2024
55252b8
Fix newplus
stefansjfw Oct 21, 2024
e03a9e8
Fix stuck on restart and terminate AdvPaste exe on destroy()
stefansjfw Oct 21, 2024
68fa66a
[Installer] Add tracer
stefansjfw Oct 21, 2024
8a8874e
Address PR comment
stefansjfw Oct 21, 2024
b06967e
Add missing tracers
stefansjfw Oct 23, 2024
13146fa
Exclude etw dir from BugReport
stefansjfw Oct 23, 2024
e7e8068
Merge remote-tracking branch 'origin/main' into stefan/opt_in_telem
stefansjfw Oct 23, 2024
db8fdc1
Fix bad merge
stefansjfw Oct 23, 2024
edb7887
[Hosts] Proper exit on initial dialog
stefansjfw Oct 23, 2024
699a06e
[OOBE] Make Data diagnostic setting visible without scroll
stefansjfw Oct 23, 2024
1c2ba01
[OOBE] Add hiperlynk to open general settings
stefansjfw Oct 23, 2024
445f053
Disable data view on disabling data diagnostics
stefansjfw Oct 23, 2024
f8af582
Don't disable View data button
stefansjfw Oct 23, 2024
75eeadc
Fix disabling data viewing
stefansjfw Oct 23, 2024
b528976
Merge remote-tracking branch 'origin/main' into stefan/opt_in_telem
stefansjfw Oct 24, 2024
717cdd3
Add missing dot
stefansjfw Oct 24, 2024
c289552
Revert formatting
stefansjfw Oct 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 8 additions & 19 deletions .github/actions/spell-check/expect.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ AMPROPSETID
amr
ANDSCANS
animatedvisuals
anr
ansicolor
ANull
AOC
Expand All @@ -57,14 +58,12 @@ APPBARDATA
appdata
APPEXECLINK
Appium
applayout
Applicationcan
APPLICATIONFRAMEHOST
appmanifest
APPNAME
appref
appsettings
appsfolder
appwindow
appwiz
APSTUDIO
Expand Down Expand Up @@ -145,7 +144,6 @@ BTNFACE
bugreport
BUILDARCH
BUILDNUMBER
buildtask
buildtransitive
BVal
BValue
Expand Down Expand Up @@ -269,7 +267,6 @@ CSettings
cso
CSRW
CStyle
cswinrt
CSY
CTest
currentculture
Expand Down Expand Up @@ -351,7 +348,6 @@ devpkey
DEVSOURCE
DIIRFLAG
dimm
directshow
DISABLEASACTIONKEY
diskmgmt
DISPLAYCHANGE
Expand All @@ -367,7 +363,6 @@ dllmain
DNLEN
DONOTROUND
DONTVALIDATEPATH
DOPUS
dotnet
DPICHANGED
DPIs
Expand Down Expand Up @@ -450,12 +445,13 @@ erwrite
ESettings
esrp
etl
ETW
etw
EUQ
eurochange
eventlog
eventvwr
everytime
evntrace
evt
EWXFORCE
EWXFORCEIFHUNG
Expand Down Expand Up @@ -527,7 +523,6 @@ FZE
gacutil
Gaeilge
Gaidhlig
GBarm
GCLP
gdi
gdiplus
Expand Down Expand Up @@ -997,7 +992,6 @@ NCRENDERING
ndp
NEEDDISPATCH
needinfo
netcore
netcoreapp
netcpl
netframework
Expand All @@ -1006,6 +1000,7 @@ netsh
newcolor
newdev
NEWDIALOGSTYLE
NEWFILE
newitem
newpath
newplus
Expand Down Expand Up @@ -1074,7 +1069,6 @@ NTAPI
ntdll
ntfs
NTSTATUS
nugets
nullonfailure
numberbox
nwc
Expand Down Expand Up @@ -1225,6 +1219,7 @@ proactively
PROCESSENTRY
PROCESSKEY
processthreadsapi
PROCESSTRACE
PRODEXT
PRODUCTVERSION
Progman
Expand Down Expand Up @@ -1266,7 +1261,6 @@ PWSTR
pwsz
pwtd
QDC
QDir
qianlifeng
qit
QITAB
Expand Down Expand Up @@ -1590,9 +1584,7 @@ SYSKEYUP
SYSLIB
SYSMENU
SYSTEMAPPS
SYSTEMSETTINGS
SYSTEMTIME
SYSTEMWOW
tapp
TApplication
TApplied
Expand All @@ -1612,7 +1604,6 @@ TCustom
tdbuild
TDefault
TDevice
telem
telephon
templatenamespace
testprocess
Expand Down Expand Up @@ -1644,11 +1635,12 @@ toolkitconverters
Toolset
toolwindow
TOPDOWNDIB
TOTALCMD
TOUCHEVENTF
TOUCHINPUT
touchpad
TRACEHANDLE
tracelogging
tracerpt
trafficmanager
traies
transicc
Expand Down Expand Up @@ -1706,11 +1698,9 @@ urlmon
Usb
USEDEFAULT
USEFILEATTRIBUTES
USEPOSITION
USERDATA
Userenv
USESHOWWINDOW
USESIZE
USESTDHANDLES
USRDLL
UType
Expand Down Expand Up @@ -1803,7 +1793,6 @@ wgpocpl
WIC
wil
winapi
winappdriver
wincodec
Wincodecsdk
wincolor
Expand Down Expand Up @@ -1867,6 +1856,7 @@ WNDCLASSEX
WNDCLASSEXW
WNDCLASSW
WNDPROC
wnode
workarounds
WORKSPACESEDITOR
WORKSPACESLAUNCHER
Expand Down Expand Up @@ -1912,7 +1902,6 @@ XNamespace
Xoshiro
XPels
XPixel
xplorer
XResource
xsi
XStr
Expand Down
2 changes: 1 addition & 1 deletion .pipelines/packages.config
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Microsoft.PowerToys.Telemetry" version="2.0" />
<package id="Microsoft.PowerToys.Telemetry" version="2.0.2" />
</packages>
4 changes: 2 additions & 2 deletions .pipelines/v2/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ extends:

- script: |
call nuget.exe restore -configFile .pipelines/release-nuget.config -PackagesDirectory . .pipelines/packages.config || exit /b 1
move /Y "Microsoft.PowerToys.Telemetry.2.0.0\build\include\TraceLoggingDefines.h" "src\common\Telemetry\TraceLoggingDefines.h" || exit /b 1
move /Y "Microsoft.PowerToys.Telemetry.2.0.0\build\include\TelemetryBase.cs" "src\common\Telemetry\TelemetryBase.cs" || exit /b 1
move /Y "Microsoft.PowerToys.Telemetry.2.0.2\build\include\TraceLoggingDefines.h" "src\common\Telemetry\TraceLoggingDefines.h" || exit /b 1
move /Y "Microsoft.PowerToys.Telemetry.2.0.2\build\include\TelemetryBase.cs" "src\common\Telemetry\TelemetryBase.cs" || exit /b 1
displayName: Emplace telemetry files

- stage: Publish
Expand Down
1 change: 1 addition & 0 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
<PackageVersion Include="MessagePack" Version="2.5.187" />
<PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0" />
<PackageVersion Include="Microsoft.Data.Sqlite" Version="8.0.7" />
<PackageVersion Include="Microsoft.Diagnostics.Tracing.TraceEvent" Version="3.1.16" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
Expand Down
1 change: 1 addition & 0 deletions NOTICE.md
Original file line number Diff line number Diff line change
Expand Up @@ -1320,6 +1320,7 @@ EXHIBIT A -Mozilla Public License.
- MessagePack 2.5.187
- Microsoft.CodeAnalysis.NetAnalyzers 8.0.0
- Microsoft.Data.Sqlite 8.0.7
- Microsoft.Diagnostics.Tracing.TraceEvent 3.1.16
- Microsoft.Extensions.DependencyInjection 8.0.0
- Microsoft.Extensions.Hosting 8.0.0
- Microsoft.Extensions.Hosting.WindowsServices 8.0.0
Expand Down
16 changes: 16 additions & 0 deletions PowerToys.sln
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Telemetry", "Telemetry", "{
ProjectSection(SolutionItems) = preProject
src\common\Telemetry\ProjectTelemetry.h = src\common\Telemetry\ProjectTelemetry.h
src\common\Telemetry\TelemetryBase.cs = src\common\Telemetry\TelemetryBase.cs
src\common\Telemetry\TraceBase.h = src\common\Telemetry\TraceBase.h
src\common\Telemetry\TraceLoggingDefines.h = src\common\Telemetry\TraceLoggingDefines.h
EndProjectSection
EndProject
Expand Down Expand Up @@ -624,6 +625,8 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "WorkspacesLauncher", "src\m
EndProject
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "WorkspacesWindowArranger", "src\modules\Workspaces\WorkspacesWindowArranger\WorkspacesWindowArranger.vcxproj", "{37D07516-4185-43A4-924F-3C7A5D95ECF6}"
EndProject
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "EtwTrace", "src\common\Telemetry\EtwTrace\EtwTrace.vcxproj", "{8F021B46-362B-485C-BFBA-CCF83E820CBD}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MouseWithoutBorders.UnitTests", "src\modules\MouseWithoutBorders\MouseWithoutBorders.UnitTests\MouseWithoutBorders.UnitTests.csproj", "{66614C26-314C-4B91-9071-76133422CFEF}"
EndProject
Global
Expand Down Expand Up @@ -2750,6 +2753,18 @@ Global
{37D07516-4185-43A4-924F-3C7A5D95ECF6}.Release|x64.Build.0 = Release|x64
{37D07516-4185-43A4-924F-3C7A5D95ECF6}.Release|x86.ActiveCfg = Release|x64
{37D07516-4185-43A4-924F-3C7A5D95ECF6}.Release|x86.Build.0 = Release|x64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Debug|ARM64.ActiveCfg = Debug|ARM64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Debug|ARM64.Build.0 = Debug|ARM64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Debug|x64.ActiveCfg = Debug|x64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Debug|x64.Build.0 = Debug|x64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Debug|x86.ActiveCfg = Debug|x64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Debug|x86.Build.0 = Debug|x64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Release|ARM64.ActiveCfg = Release|ARM64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Release|ARM64.Build.0 = Release|ARM64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Release|x64.ActiveCfg = Release|x64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Release|x64.Build.0 = Release|x64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Release|x86.ActiveCfg = Release|x64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Release|x86.Build.0 = Release|x64
{66614C26-314C-4B91-9071-76133422CFEF}.Debug|ARM64.ActiveCfg = Debug|ARM64
{66614C26-314C-4B91-9071-76133422CFEF}.Debug|ARM64.Build.0 = Debug|ARM64
{66614C26-314C-4B91-9071-76133422CFEF}.Debug|x64.ActiveCfg = Debug|x64
Expand Down Expand Up @@ -2991,6 +3006,7 @@ Global
{367D7543-7DBA-4381-99F1-BF6142A996C4} = {A2221D7E-55E7-4BEA-90D1-4F162D670BBF}
{2CAC093E-5FCF-4102-9C2C-AC7DD5D9EB96} = {A2221D7E-55E7-4BEA-90D1-4F162D670BBF}
{37D07516-4185-43A4-924F-3C7A5D95ECF6} = {A2221D7E-55E7-4BEA-90D1-4F162D670BBF}
{8F021B46-362B-485C-BFBA-CCF83E820CBD} = {8F62026A-294B-41C6-8839-87463613F216}
{66614C26-314C-4B91-9071-76133422CFEF} = {B6C42F16-73EB-477E-8B0D-4E6CF6C20AAC}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
Expand Down
10 changes: 10 additions & 0 deletions installer/PowerToysSetup.sln
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ Project("{930C7802-8A8C-48F9-8165-68863BCCD9DD}") = "PowerToysBootstrapper", "Po
EndProject
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Version", "..\src\common\version\version.vcxproj", "{CC6E41AC-8174-4E8A-8D22-85DD7F4851DF}"
EndProject
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "EtwTrace", "..\src\common\Telemetry\EtwTrace\EtwTrace.vcxproj", "{8F021B46-362B-485C-BFBA-CCF83E820CBD}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|ARM64 = Debug|ARM64
Expand Down Expand Up @@ -68,6 +70,14 @@ Global
{CC6E41AC-8174-4E8A-8D22-85DD7F4851DF}.Release|ARM64.Build.0 = Release|ARM64
{CC6E41AC-8174-4E8A-8D22-85DD7F4851DF}.Release|x64.ActiveCfg = Release|x64
{CC6E41AC-8174-4E8A-8D22-85DD7F4851DF}.Release|x64.Build.0 = Release|x64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Debug|ARM64.ActiveCfg = Debug|ARM64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Debug|ARM64.Build.0 = Debug|ARM64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Debug|x64.ActiveCfg = Debug|x64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Debug|x64.Build.0 = Debug|x64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Release|ARM64.ActiveCfg = Release|ARM64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Release|ARM64.Build.0 = Release|ARM64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Release|x64.ActiveCfg = Release|x64
{8F021B46-362B-485C-BFBA-CCF83E820CBD}.Release|x64.Build.0 = Release|x64
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
Loading
Loading