chore: use contentFrame() as a canonical locator representation #32697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Sep 19, 2024
f0cc0be
to
1db7049
Compare
This comment has been minimized.
This comment has been minimized.
1db7049
to
136741f
Compare
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Sep 19, 2024
docs/src/api/class-framelocator.md
Outdated
| @@ -82,6 +82,7 @@ If you have a [FrameLocator] object it can be converted to [Locator] pointing to | |||
|
|
|||
|
|
|||
| ## method: FrameLocator.first | |||
| * deprecated: You should use [`method: Locator.first`] followed by [`method: Locator.contentFrame`] instead. | |||
136741f
to
9b23561
Compare
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Sep 19, 2024
9b23561
to
7d3c8e2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7d3c8e2
to
6be6f32
Compare
Test results for "tests 1"3 failed 1 flaky35508 passed, 659 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.