Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove windows CI/CD for now #20441

Merged
merged 2 commits into from
Sep 16, 2024
Merged

remove windows CI/CD for now #20441

merged 2 commits into from
Sep 16, 2024

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

remove windows CI/CD for now

Motivation and Context

windows port is decided to be community
only support and source compile-friendly.

How to test this PR?

CI/CD is disabled, so the rest will follow.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

shtripat
shtripat approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@klauspost
Copy link
Contributor

Just to save on CPU? Not sure I understand the point.

@harshavardhana
Copy link
Member Author

harshavardhana commented Sep 16, 2024 •
edited
Loading

Just to save on CPU? Not sure I understand the point.

No more Windows builds necessary from shipping and releasing binary for community releases. If go install works that is sufficient, no need to run go test etc.

If needed we will keep it for our paid customers, we hardly have any for windows.

@harshavardhana
remove windows CI/CD for now
bde0f66 
windows is decided to be community support
only and source compile friendly.
@harshavardhana harshavardhana force-pushed the disable-windows branch 2 times, most recently from 2be7df0 to 994dd25 Compare September 16, 2024 19:13
@harshavardhana harshavardhana merged commit 70d4008 into minio:master Sep 16, 2024
20 checks passed
@harshavardhana harshavardhana deleted the disable-windows branch September 16, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shtripat shtripat shtripat approved these changes

@poornas poornas poornas approved these changes

@vadmeste vadmeste vadmeste approved these changes

@klauspost klauspost Awaiting requested review from klauspost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harshavardhana @klauspost @vadmeste @poornas @shtripat