Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ListAccessKeysBulk API for builtin user access keys #20381

Merged
merged 13 commits into from
Sep 21, 2024
Merged

Add ListAccessKeysBulk API for builtin user access keys #20381

merged 13 commits into from
Sep 21, 2024

Conversation

taran-p
Copy link
Contributor

@taran-p taran-p commented Sep 4, 2024 •
edited
Loading

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Adds ListAccessKeysBulk API to list access keys for specified or all builtin users. Analogous to the ListAccessKeysLDAPBulk API but for builtin users.

Motivation and Context

There is no no equivalent for ListAccessKeysLDAPBulk for builtin users.

How to test this PR?

Use minio/mc#5038 with mc admin accesskey list.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

shtripat
shtripat reviewed Sep 5, 2024
View reviewed changes
cmd/admin-handlers-users.go Outdated Show resolved Hide resolved
cmd/admin-handlers-users.go Show resolved Hide resolved
cmd/admin-handlers-users.go Outdated Show resolved Hide resolved
cmd/admin-handlers-users.go Outdated Show resolved Hide resolved
cmd/admin-handlers-users.go Outdated Show resolved Hide resolved
@taran-p taran-p mentioned this pull request Sep 19, 2024
Merged
8 tasks
@taran-p taran-p marked this pull request as ready for review September 19, 2024 22:09
shtripat
shtripat approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me. tested with corresponding mc PR

@harshavardhana
Copy link
Member

Please resolve the conflicts @taran-p

@taran-p
Copy link
Contributor Author

taran-p commented Sep 21, 2024

@harshavardhana resolved

@harshavardhana harshavardhana merged commit 78fcb76 into minio:master Sep 21, 2024
21 checks passed
@taran-p taran-p deleted the accesskey-changes branch September 21, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shtripat shtripat shtripat approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@donatello donatello Awaiting requested review from donatello

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taran-p @harshavardhana @shtripat