Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 0.27.0.dev0 #3681

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Bump version to 0.27.0.dev0 #3681

merged 6 commits into from
Oct 25, 2024

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Oct 24, 2024 •
edited
Loading

Bump version to 0.27.0.dev0.

Removes fsdp_config and fsdp_auto_wrap Trainer parameters.

@irenedea irenedea force-pushed the bump_version_0.27.0.dev0 branch 2 times, most recently from b59c0de to 77347ff Compare October 24, 2024 23:32
@irenedea irenedea marked this pull request as ready for review October 24, 2024 23:49
@irenedea irenedea requested a review from a team as a code owner October 24, 2024 23:49
mvpatel2000
mvpatel2000 reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requiring @dakinggg to sign off on deprecation to avoid some hiccups like before but LGTM

dakinggg
dakinggg approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might try to sneak #3682 in before release.

bigning
bigning approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@bigning bigning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@irenedea irenedea merged commit d247e26 into main Oct 25, 2024
26 checks passed
@irenedea irenedea deleted the bump_version_0.27.0.dev0 branch October 25, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 left review comments

@bigning bigning bigning approved these changes

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irenedea @bigning @mvpatel2000 @dakinggg