Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add crawler support for Nuxt 3 #145

Merged
merged 2 commits into from
Apr 12, 2023
Merged

feat: add crawler support for Nuxt 3 #145

merged 2 commits into from
Apr 12, 2023
+88 −28

Conversation

yassilah
Copy link
Collaborator

@yassilah yassilah commented Apr 5, 2023

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #144

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@nuxt-studio
Copy link

nuxt-studio bot commented Apr 5, 2023 •
edited
Loading

✅ Live Preview ready!

Name Edit Preview Latest Commit
Algolia Edit on Studio ↗︎ View Live Preview 5181965

@yassilah
Copy link
Collaborator Author

yassilah commented Apr 5, 2023

it was almost too easy to add Nuxt 3 support but it seems to be working fine, so I guess we can once again just thank the Nuxt team for being so good at what they do aha 🚀

@yassilah yassilah requested a review from Baroshem April 6, 2023 06:53
@Baroshem
Copy link
Collaborator

Baroshem commented Apr 6, 2023

Hey hey,

Thanks for this PR. I will approve it and wait for one more PR to be merged so that I can release a full new version :)

@Baroshem Baroshem merged commit ffc7a2f into main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baroshem Baroshem Baroshem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSG crawler support for Nuxt 3
2 participants
@yassilah @Baroshem