feat: soundboard #1112
Draft
feat: soundboard #1112
+509
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teaishealthy
commented
Aug 18, 2023
EmmmaTech
requested changes
Aug 19, 2023
| return self._state._upgrade_partial_soundboard_sound(partial) | ||
|
|
||
| def __repr__(self) -> str: | ||
| return f"<VoiceChannelEffect channel_id={self.channel_id} guild_id={self.guild_id} user_id={self.user_id} emoji={self.emoji} animation_type={self.animation_type} animation_id={self.animation_id} sound_id={self.sound_id} sound_override_path={self.sound_override_path} sound_volume={self.sound_volume}>" |
There was a problem hiding this comment.
Should all of these attributes be in the repr? It seems excessive.
There was a problem hiding this comment.
This is a temporary thing. I just wanted something for debugging so i didn't have to look at the default repr. I'm going to give it more thought later
Co-Authored-By: EmreTech <50607143+emretech@users.noreply.github.com>
…ake into teaishealthy/issue1047
EmmmaTech
requested changes
Aug 26, 2023
Comment on lines
+30
to
+32
| sound_id: int, | ||
| sound_override_path: Optional[str], | ||
| sound_volume: Optional[float], |
There was a problem hiding this comment.
Why are these parameters prefixed with sound_ when the attributes aren't?
| from .types.voice import VoiceChannelEffectSend as VoiceChannelEffectSendPayload | ||
|
|
||
|
|
||
| class VoiceChannelEffect: |
There was a problem hiding this comment.
Make sure to add __slots__.
Co-Authored-By: EmreTech <50607143+emretech@users.noreply.github.com>
|
i will pick this up again soon |
i lied, pr is available to be picked up by someone else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement soundboard and the Voice Channel Effect Send event. Closes #1047
discord/discord-api-docs#6025
discord/discord-api-docs#6260
idis the samesound_id, just not available sometimes? ¯\_(ツ)_/¯This is a Code Change
task pyrightand fixed the relevant issues.TODO
Guildthat requests sounds andwait_fors the sound data ➞fetch_soundboard_soundsMaybe
Assetrework into ➞ intoSoundAssetand ?Asset