Skip to content

Switch from using save_analysis_ready_reads to save_analysis_ready_fa… #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 12, 2025
Merged

Switch from using save_analysis_ready_reads to save_analysis_ready_fa… #586

merged 4 commits into from
Mar 12, 2025

Conversation

epstein6
Copy link
Contributor

@epstein6 epstein6 commented Mar 11, 2025 •
edited
Loading

…stqs in docs.

The option as described in the docs didn't exist.

PR checklist

  • This comment contains a description of changes (with reason).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.

LilyAnderssonLee
LilyAnderssonLee reviewed Mar 12, 2025
View reviewed changes
Copy link
Contributor

@LilyAnderssonLee LilyAnderssonLee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add this PR change to the CHANGELOG.md.

@epstein6
Copy link
Contributor Author

Added!

@LilyAnderssonLee
Copy link
Contributor

And also add yourself to the list of contributors on the README.md

@epstein6
Copy link
Contributor Author

Done, hope that's the right place.

LilyAnderssonLee
LilyAnderssonLee approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@LilyAnderssonLee LilyAnderssonLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it once all tests have passed.

@LilyAnderssonLee LilyAnderssonLee merged commit 26d0721 into nf-core:dev Mar 12, 2025
26 checks passed
@jfy133
Copy link
Member

jfy133 commented Mar 12, 2025

Thank you @epstein6 !

@epstein6
Copy link
Contributor Author

Thank you both for helping with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyAnderssonLee LilyAnderssonLee LilyAnderssonLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epstein6 @LilyAnderssonLee @jfy133