Skip to content

Json schema improvements #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 16, 2025
Merged

Json schema improvements #592

merged 5 commits into from
Apr 16, 2025

Conversation

microlei
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • [ NA] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • [NA] If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • [NA] Usage Documentation in docs/usage.md is updated.
  • [NA] Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • [NA] README.md is updated (including new tool citations and authors/contributors).

nvnieuwk
nvnieuwk reviewed Mar 25, 2025
View reviewed changes
CHANGELOG.md Outdated

### `Fixed`

- improved json schema as part of nf-core hackathon 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this changelog entry look like the other entries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to add a PR number?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :)

nvnieuwk
nvnieuwk reviewed Mar 25, 2025
View reviewed changes
nvnieuwk
nvnieuwk reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, very well done! Here are some comments

nvnieuwk
nvnieuwk approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@jen-reeve jen-reeve linked an issue Mar 26, 2025 that may be closed by this pull request
JSON schema: Taxprofiler #590
Closed
15 tasks
@jfy133
Copy link
Member

jfy133 commented Apr 16, 2025

@nf-core-bot fix linting

jfy133
jfy133 approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @microlei ! This completely slipped us by!

@jfy133 jfy133 merged commit fbca4b1 into nf-core:dev Apr 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

@nvnieuwk nvnieuwk nvnieuwk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON schema: Taxprofiler
4 participants
@microlei @jfy133 @nvnieuwk @nf-core-bot