Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure and improve MIME types configuration #139

Closed
wants to merge 1 commit into from

Conversation

LeoColomb
Copy link

@LeoColomb LeoColomb commented Sep 9, 2024

Proposed changes

Based on the work done under the project H5BP (disclaimer: I'm the maintainer), this change improves the structure of the MIME type configuration and brings the latest standard updates to its values.

All the types have been tested against the project Media Type Database, referencing the industry standard, un-opinionated, MIME-types uses.

This change would help to deliver correct MIME types out of the box, and reduce mismatching as much as possible.

Closes #137
Closes #125

Based on the work done under the [h5bp][1], this change improves the structure of the MIME type configuration and brings the latest [standard updates][2] to its values.

[1]: https://github.com/h5bp/server-configs-nginx
[2]: https://www.iana.org/assignments/media-types/media-types.xhtml
@arut arut added the mime label Sep 10, 2024
@viktorberezikov
Copy link
Member

The purpose of the conf/mime.types example configuration is to instruct nginx that it should automatically apply the specific Content-Type header based on the file extension when it sends local files. To be clear, it does not work for proxied responses.

Regarding the fundamental increasing of the MIME types list. It seems that extensions of this example should be reasonable. In addition to existing in IANA media types should be supported by popular clients/browsers. Randomly adding rare and ambiguous MIME types does not look useful. At the same time, specific needs/types can always be configured based on the example.

As for the current pull request. Could you please clarify the reasons why you add and change the position for so many MIME types? It looks like a lot of MIME types are not well supported by clients/browsers.

As for the #125 and #137 pull requests. There are relevant answers there, too.

tats-u added a commit to tats-u/nginx that referenced this pull request Sep 12, 2024
@LeoColomb LeoColomb closed this by deleting the head repository Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants