ngx_http_limit_req_module: add "r/h" (request per hour), "r/d" (request per day) support #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace rate/excess/burst scale multiplier 1000 constant with MACRO definition
add "r/h"(request per hour), "r/d"(request per day) support
|
The leaky bucket algorithm, as limit_req uses, is (very) poorly suited to rate limiting over long intervals such as hours or a days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngx_http_limit_req_module: add "r/h"(request per hour), "r/d"(request per day) support
by two steps:
1、replace the scale multiplier(1000) constant with MACRO definition
2、change the scale multipiler from 1000 to 1000000 to support new "r/h", "r/d" options