Skip to content

fix(store): createPickSelector should not throw on unregistered states #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2025
Merged

fix(store): createPickSelector should not throw on unregistered states #2378

merged 2 commits into from
Oct 2, 2025

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Oct 2, 2025

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 2, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 055c31f

Command Status Duration Result
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=lint --all --configuration... ✅ Succeeded 1s View ↗
nx run-many --target=test --all --configuration... ✅ Succeeded 2s View ↗
nx run-many --target=build --all ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-02 12:49:52 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 2, 2025

Open in StackBlitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2378

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2378

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2378

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2378

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2378

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2378

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2378

commit: 447cead

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 2, 2025 •
edited
Loading

BundleMon

Unchanged files (6)
Status Path Size Limits
✅ fesm2022/ngxs-store.mjs
 104.46KB 105KB / +0.5%
✅ fesm2022/ngxs-store-internals.mjs
 13.6KB 15KB / +0.5%
✅ fesm2022/ngxs-store-internals-testing.mjs
 10.32KB 13KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.05KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.37KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 574B 2KB / +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 33.69KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 2, 2025 •
edited
Loading

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 4.05KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 3.4KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.72KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.58KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.47KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.23KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.03KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 947B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 453B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.85KB +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 2, 2025 •
edited
Loading

BundleMon (Integration Projects)

Unchanged files (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng20/dist-integration/browser/mai
n-(hash).js
 67.21KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@arturovt arturovt merged commit 49efc08 into master Oct 2, 2025
1 of 2 checks passed
@arturovt arturovt deleted the fix/selectors branch October 2, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arturovt