Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move browser checks to browser.js #1009

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Move browser checks to browser.js #1009

merged 1 commit into from
Feb 1, 2018

Conversation

juanjoDiaz
Copy link
Contributor

Just move all the duplicate isMac, isWindow, etc. to browser.js

@DirectXMan12 DirectXMan12 added this to the Future Features milestone Jan 30, 2018
DirectXMan12
DirectXMan12 approved these changes Jan 30, 2018
View reviewed changes
Copy link
Member

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once @samhed cuts v1.0.0

@juanjoDiaz
Copy link
Contributor Author

Any ETA for that?
I have more PRs for the eslint stuff sort of waiting for this to avoid conflicts.

CendioOssman
CendioOssman approved these changes Jan 31, 2018
View reviewed changes
Copy link
Member

@CendioOssman CendioOssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, looks good.

@CendioOssman
Copy link
Member

Any ETA for that?
I have more PRs for the eslint stuff sort of waiting for this to avoid conflicts.

I was hoping to get the beta out this week, but we probably want to let that be tested for a while before doing the final version. So it could be a while.

Perhaps it's better if you just use #1005 and put each suggestion as a separate commit rather than a separate PR? That way everything can be reviewed and done without having to wait for partial merges.

@DirectXMan12
Copy link
Member

I've been gradually merging stuff that's not majorly impactful. This is relatively minor, so it might be fine to merge pre-1.0, especially with the plan to do a beta.

@juanjoDiaz
Copy link
Contributor Author

That would be great :)

@DirectXMan12
Copy link
Member

@CendioOssman @samhed any objections to just merging this now?

@samhed
Copy link
Member

samhed commented Feb 1, 2018

works for me

@CendioOssman
Copy link
Member

Yeah, this isn't too scary. So go ahead.

@DirectXMan12 DirectXMan12 merged commit a4d51bd into novnc:master Feb 1, 2018
@DirectXMan12 DirectXMan12 modified the milestones: Future Features, v1.0.0 Feb 1, 2018
@samhed samhed added the cleanup label Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 DirectXMan12 approved these changes

@CendioOssman CendioOssman CendioOssman approved these changes

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@juanjoDiaz @CendioOssman @DirectXMan12 @samhed