Add S3 bucket configuration instructions to the prerequisite section #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides additional information, without which it is difficult to get an S3-hosted app template up and running successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides additional information, without which it is difficult to get an S3-hosted app template up and running successfully.
I'm making the PR to this documentation because this blog post is referenced in https://github.com/nprapps/app-template#about-this-template as being the resource for people outside NPR seeking to use the app template for themselves.
In discussion in #helpme in the newsnerdery.org slack on Friday, September 1, 2017, multiple other people mentioned they had run into the problem I ran into: a newly-created bucket was not publicly accessible as a website. Adding bucket configuration to the instructions would hopefully lessen the chance of that happening in the future.
However: accepting this PR means that you're linking to Amazon's documentation, the URLs for which may change without notice. Hopefully if Amazon changes these URLs they'll set up redirects, or someone will let you know that the links are broken, and the links will be able to be updated.
If the lawyers ask: yes, I grant NPR the necessary licenses to use this content. If there's paperwork that needs to be signed, let me know and we'll figure that out.