Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semantics): support asIteration() for _iter nodes #472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DonIsaac
Copy link

What This PR Does

Adds support for the builtin asIteration() semantic operation to _iter nodes.

Before, calling someIterNode.asIteration() would throw this error:

missingSemanticAction: Missing semantic action for '_iter' in operation 'asIteration'.
NOTE: as of Ohm v16, there is no default action for iteration nodes — see 
  https://ohmjs.org/d/dsa for details.

Now, asIteration() will just return the _iter node it was called on.

Why?

I often found myself switching between +/* and ListOf while writing grammars. This allows semantics to continue to work as intended without changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant