Close discussions #3097
-
|
As it goes with any discussion, there is a natural point a discussion comes to an end. Sadly, currently, I cannot find a way to close a discussion .. only to lock the conversation. The reason we would like this: Currently we are using Discussions to talk over feature requests, as it has a more natural format for that (being able to reply to a comment is really helpful here). But as time goes on, either the feature request gets implemented or is rejected. In either case, we would like to mark the Discussion as such, without being all evil and locking anyone from continue the conversation if there is a need. Very similar to issues and PRs. Now we notice people are unaware a feature has either been rejected or implemented, and keep contributing to something already decided. This requires us to change the original post to note this, but it is a very annoying workflow. Especially as there is also no way to label discussions. Easier would be if there was a category-type that would lend itself for this workflow, where we can just mark a Discussion as "closed" or "resolved" or similar. Not so much as a QA, as there is no right answer. Would this be possible? Or is it already, and am I just overlooking this? Thank you! |
Beta Was this translation helpful? Give feedback.
Replies: 35 comments 25 replies
-
|
Same exact use case here: I'm using discussions for feature requests and it would be very useful to mark them as done/rejected. Right now there's no way of looking at the feature requests list and tell which one are pending and which one are completed. Alternatively to closing discussions, it would be interesting to be able to convert them to issues (which would enable to close them via a PR, for example) |
Beta Was this translation helpful? Give feedback.
-
|
I mentioned feature requests because "Ideas for new features" is literally one the default categories when you enable Discussions on a project: If feature requests don't belong to Discussions, then I would propose to remove that default option because it's quite crucial for feature requests to be addressable in some way (mark them as done, rejected, or in progress, for instance) |
Beta Was this translation helpful? Give feedback.
-
|
AFAIK, there's no public-accepted convention of the difference between issues and discussions. But I believe it doesn't make sense to use different systems for feature requests and bug reports. On the first day Discussions was in public beta, another maintainer of CP Editor converted several feature requests into discussions without my acknowledgment, so now I'm eagerly waiting for #2861. So I'd agree that it shouldn't be encouraged to use Discussions for feature requests in the UI of GitHub. |
Beta Was this translation helpful? Give feedback.
-
|
In my experience feature requests tend to be very noisy (since anyone can propose one and then they stay open for a long time) and I've always liked managing them separately than issue trackers. For instance, in Metals we use a separate repo for tracking feature requests and we use a GitHub action to generate a summary table sorted by 👍 reactions in a pinned issue in the main repo. This way we have a manageable issue tracker focused on bugs and actionable features, while all the ideas can float around in the other repo. I think Discussions with upvoting would be great for this use-case, if only we could then either close them or turn them into issues when we start working on them. |
Beta Was this translation helpful? Give feedback.
-
That's what I think "can be closed by a PR". I agree that an immature idea should be in the Discussions. |
Beta Was this translation helpful? Give feedback.
-
I'll disagree here. We use Jira for issue tracking (including feature requests). However, Discussions is a much better format for, well, discussions about features as well as other things that do not fit into issue tracking. Granted, eventually feature discussions get to a "resolution" at which point there would be a Jira created with a link to the discussion. Jira is simply not a good tool for this |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the feedback! We are tracking this request on our end and using this thread to gauge customer impact via upvotes and reactions. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @evi-liu, I suppose this feature is a generalisation of the "Answered" thing for questions, but that work for all the categories... |
Beta Was this translation helpful? Give feedback.
-
|
Hi @evi-liu, any update on the feasibility of this feature being incorporated? It has quite a few upvotes, and we at Filecoin Foundation and Protocol Labs would also benefit from this enhancement. |
Beta Was this translation helpful? Give feedback.
-
|
I would also like this. It cannot be determined from the discussions listing whether a "general discussion" has been resolved. For Q&A there's a green check mark but for general discussion the options are lock or delete. I don't want to do either, I just want some way to mark it that the discussion is resolved. If a general discussion can't be answered, it can be resolved /ended with a green check mark. Right now we have two general discussions, one has resolved itself, and one has ended, but no way to signal they've ended. |
Beta Was this translation helpful? Give feedback.
-
|
Another use case from my team at Athens Research https://github.com/athensresearch/athens/blob/master/README.md We are an active and growing community around an open source product and are looking for ways to make feature requests more tractable. The voting system in the discussions section is great because it allows us to see which features are the most requested (or will at least when we get more momentum using it for feature requests). I'm already anticipating the challenges mentioned by posters above. I'm imagining that where you are able to select the discussion format (currently the options are Q&A and open discussion) you might have a feature request format that allows discussions to be marked as closed or resolved. Likewise I could see a discussion format option with custom parameters that might allow for other use cases as well. Looking forward to a solution. If I can be of any more help please let me know! Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
+1 for this feature. We're using Discussions for our Triage and it's working well for us. As a temporary workaround, we created an |
Beta Was this translation helpful? Give feedback.
-
|
Great workaround, we're going to try that as well for now. Downsides:
|
Beta Was this translation helpful? Give feedback.
-
|
Agreed on the downsides. I think we may "solve" this by updating the description with the changes. |
Beta Was this translation helpful? Give feedback.
-
|
Another workaround: we hit upon the idea of locking obsolete discussions and then filtering the top view.
Proposed for prioritization in #3568 |
Beta Was this translation helpful? Give feedback.
-
|
I also have a similar usecase, features have already been implemented but the discussion didn't reflect that. A way to a close/archive discussions would be much appreciated. |
Beta Was this translation helpful? Give feedback.
-
|
We at JSON Schema are trialing Discussions as a non-ephemeral (ahem free Slack) place to make suggestions about how to operate as an open source community, project vision, and our direction. We would love to be able to mark discussions as resolved without locking them, and have some sort of default filter. Resolved / archived seems like the right thing here. Discussions that result in actions will be tracked by Issues if a consensus of action is reached, but we got to get there first. My feeling is we want to rasie an Issue when there's work to be done. |
Beta Was this translation helpful? Give feedback.
-
|
still actual! |
Beta Was this translation helpful? Give feedback.
-
|
also see #4026 |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see an archive option for a discussion, something that works like issues being closed. You can go to the closed/archived tab to see them if needed, but only active discussions are shown by default. |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, I like the idea of having a 'close' state for discussions. If someone opens a discussion that's off-topic or in the wrong-place, there's not really a way to 'close' it and remove it from the top of the list of discussions. You don't always want to delete these threads though as it may help folks searching with similar questions to get context or pointers to where to go for answers in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I will upvote this feature. I would love for the ability to close discussions and archive them without deleting them. Once closed or archived, they shouldn't show up in the new or top. But can still be searched and possibly a selection called show archive to show the archived post to those who need it. |
Beta Was this translation helpful? Give feedback.
-
|
+1 to this. We need a way to visually filter out closed/locked discussions at the UI. We have a huge number of discussions that were created under several categories (General, Ideas, even custom categories) and locking them does not mark them or label them anyhow at the "View all" UI, neither there is a filter for Locked/Unlocked discussions. The workaround that we are thinking of doing in the meanwhile is just to create every new discussion under the Q&A category (so that at least we can mark them as "Answered") and change the category of the discussions already locked to Q&A... but that should be a workaround. |
Beta Was this translation helpful? Give feedback.
-
|
Would definitely love to have "Close discussion" functionality that hides the discussion from the list. I'd like our team to start using GitHub Discussions to talk through various technical/product decisions, and then close once a decision has been reached and/or the topic is no longer relevant. For now I've been tagging these discussions as "Resolved", but it's definitely not ideal because they still show up alongside all the active discussions. |
Beta Was this translation helpful? Give feedback.
-
|
I'm using discussions to collect ideas to my screencast episodes from community. When I address a suggested topic, I'd love to close discussion/archive it. I don't want to fully delete any threads though. +1 for this feature. |
Beta Was this translation helpful? Give feedback.
-
|
The possibility of archiving a discussion would allow me to completely migrate from Notion. Heck, even the ability to set a default filter would be useful. However, I have to manually filter every time, which becomes tedious. |
Beta Was this translation helpful? Give feedback.
-
|
Hi! I’m a staff member at GitHub, and I’ve begun looking into this request. I had a few follow-up questions that I was hoping y’all could help me with. I know parts of these questions are covered in earlier threads, so apologies for any repetition.
Thanks for all of your feedback so far! |
Beta Was this translation helpful? Give feedback.
-
|
I would like to get "closed" discussions out of sight without locking them, because I often find it annoying to be unable to comment under a locked issue. Sometimes further discussions are needed, and I prefer locking only when there is a reason for it (e.g. for some reason, spam is likely to happen or is already happening). |
Beta Was this translation helpful? Give feedback.
-
We use discussions for internal team conversations to make decisions and external open source conversations. The problems I'm trying to solve are:
That said, having a |
Beta Was this translation helpful? Give feedback.
-
|
Locking is really strict measure that really prevents further engagement down the line if new or related issues arise. I rarely lock anything unless it'd be off-topic or spam. Marking things as an answer and closing is really about saying this discussion has concluded and isn't needed to be bubbled up to others in the list by default (they should still be searchable). |
Beta Was this translation helpful? Give feedback.
-
|
Echoing comments above, for us the goal is to have resolved open-ended conversations (typically feature requests) out of sight by default, without outright locking them (otherwise there's no ways to further comment without workarounds such as creating a new discussion). |
Beta Was this translation helpful? Give feedback.
-
|
We also want this feature for AutoKey. Locking and deleting are usually not good options. Old information is often still valuable and, sometimes, further comments are valuable. We do need to get these old/finished discussions out of view. |
Beta Was this translation helpful? Give feedback.
-
|
Hi all. It would be interesting to archive discussion in Github discussions - instead of just ending a discussion. I agree with this feature, but... I would just include the idea of archiving... as the topic could be reopened if requested. |
Beta Was this translation helpful? Give feedback.
-
|
We just started discussing architecture and API decisions in GH discussions. Once a decision is made we would like to clean the discussions up. For me it is not relevant whether it becomes read-only or not. I merely need a visual clue whether this is still an active discussion or not. |
Beta Was this translation helpful? Give feedback.
-
|
One thing that I haven't seen mentioned elsewhere is that discussions share the same numbering sequence as issues. If a bunch are added, subsequent issues get much higher numbers. While this is largely a cosmetic issue, it would be nice if discussions were numbered separately somehow, but could still have the very nice feature of short bang (#) links in other issues/discussions. Overall, having a way to close and/or archive discussions would be quite helpful. |
Beta Was this translation helpful? Give feedback.
-
|
It would be a good idea to provide this feature. |
Beta Was this translation helpful? Give feedback.
-
|
PSA : A vote is more than enough folks and won't continually ping everyone who has been watching this discussion for a long time |
Beta Was this translation helpful? Give feedback.
-
|
Related to this; I also wish there was a way to effectively close a discussion by converting it into an issue in situations where someone opens a discussion that the maintainers would rather treat as an issue. This would act a bit like "Transfer this discussion" and "Create issue from discussion" combined. Currently you can use "Create issue from discussion" and then delete discussion but you don't get a good paper trail of what your doing. If you had a way to transfer a discussion to an issue then the original (deleted) discussion could simply redirect to the new issue and the new issue could have an annotation similar to what you get when transferring issues between repositories. |
Beta Was this translation helpful? Give feedback.
-
|
Hi all, we are really excited to introduce the ability to close Discussions! Please read more about the feature here: https://github.blog/changelog/2023-03-14-adding-the-ability-to-close-github-discussions/ |
Beta Was this translation helpful? Give feedback.
-
|
Thanks! Is it possible to use the |
Beta Was this translation helpful? Give feedback.
-
IMO, when you need this, it should be an issue instead of a discussion. For example, you may briefly discuss what to do in a discussion first. When the discussion is mature enough, close the discussion and open an issue with the details. Then use a PR to close the issue. |
Beta Was this translation helpful? Give feedback.
-
|
My intended usage for this is ~feature requests (requesting a package be added to a distro). having hundreds of requests overwhelms the issue tracker and hides the actual bugs, so I don't think that'd work for me |
Beta Was this translation helpful? Give feedback.
-
|
When I search 'is:open test' the text stays in the query box but when I search 'is:opened test' the 'is:opened' part disappears. I mention this since your announcement suggests use the latter. Also is there a way to mass close many discussions at once? |
Beta Was this translation helpful? Give feedback.
-
I think it's a typo in the announcement.
Searching discussions with any invalid filters (such as |
Beta Was this translation helpful? Give feedback.
-
|
Is there a repository setting to disable or restrict this new feature to maintainers? I understand that some want the ability to close/lock/delete discussions. We're using discussions mainly for Q&A. A space where our community can ask and answer questions. I like to avoid users accidentally closing a question instead of marking it as answered. The work flow that I like to suggest for Q&A is as following: The primary way of "closing a question" is marking it as answered, if for some reason that's not possible, a maintainer can close/lock/delete a discussion in the sidebar. At the moment, closing a discussion is not restricted to maintainers. Let me know what you think. |
Beta Was this translation helpful? Give feedback.
-
|
Isn't Wiki better suited to this, once the question has been definitively answered? So promoting a discussion to wiki might be the route. |
Beta Was this translation helpful? Give feedback.
-
|
It would be nice if you are able to disable this new feature, or limit closing to only maintainers/contributors of a repository. If using discussions as a Q&A, That means if a user searches discussions for their problem, and is unfamiliar with the UI, they might not find the solution as a Limiting closing to maintainers/contributors, or a default filter of |
Beta Was this translation helpful? Give feedback.
-
|
Just to add to the point above from @markseuffert , we also have users who are satisfied with an answer, but closing the discussion instead of marking it as answered. The original purpose of discussions was to:
This new feature renders the While this feature is great for teams discussing internal feature requests etc, the implementation could be better for a community Q&A. |
Beta Was this translation helpful? Give feedback.
-
|
I think it is great to be able to close discussions. As was before, if no reply was right to be marked as "answered", one still had to pick one to kind of close a discussion (because it helps to see live discussions). Now my only request would be to close discussions through actions. |
Beta Was this translation helpful? Give feedback.
Hi all, we are really excited to introduce the ability to close Discussions! Please read more about the feature here: https://github.blog/changelog/2023-03-14-adding-the-ability-to-close-github-discussions/