Skip to content

Show correct libxc details when showing the cmake summary #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Show correct libxc details when showing the cmake summary #90

wants to merge 2 commits into from

Conversation

hservatg
Copy link

@hservatg hservatg commented Sep 8, 2025

Hello,

this tiny patch shows correct details for libxc when using cmake. Previously, I got

-- Libxc found:
--   > Libxc dir          :
--   > Libxc version      :
--   > Libxc headers      :
--   > Libxc libraries    :

With the patch, I get

-- Libxc found:
--   > Libxc dir          : /scratch/users/hservatg/ABINIT.ifx/libxc-7.0.0/build/install
--   > Libxc version      : 7.0.0
--   > Libxc cflags       : -I/scratch/users/hservatg/ABINIT.ifx/libxc-7.0.0/build/install/include/
--   > Libxc ldflags      : -L/scratch/users/hservatg/ABINIT.ifx/libxc-7.0.0/build/install/lib;-lxc

Thanks

@pkestene
Copy link
Contributor

pkestene commented Sep 8, 2025

Hi @hservatg

actually, correct details depend on how libxc is found on a given system:

  • if libxc is found via pkg_check_modules then yes your modifications are ok
  • if libxc is found via cmake find_package then the old message printing is ok

I would advise adding a cmake variable named Libxc_FOUND_via_pkgmodule defaulted to false, but set to TRUE when pkg_check_modules is successful so that you can distinguish the two different situations.

See https://github.com/abinit/abinit/blob/master/CMakeLists.txt#L489 where libxc is probed.

@hservatg
Copy link
Author

hservatg commented Sep 8, 2025

Ah, that aligns with my cmake configuration command, @pkestene .

Let me extend the patch with your suggestion.

@hservatg hservatg marked this pull request as draft September 8, 2025 15:29
@hservatg hservatg marked this pull request as ready for review September 8, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hservatg @pkestene