Update types/node16 to 20 and v3 in readmes #1326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulgens
approved these changes
Feb 13, 2024
martibenn
approved these changes
Feb 13, 2024
|
@bethanyj28, maybe you might be able to take a look at this and at the confirmed #1323? |
|
@yacaovsnc, @robherley, could you please reach out to someone to have a look at this PR and issue #1323?
|
f308c3d
to
5a51ca9
Compare
bernhardkaindl
commented
Mar 22, 2024
ShenMian
approved these changes
May 4, 2024
hamirmahal
reviewed
May 4, 2024
examples.md
Outdated
| @@ -46,7 +46,7 @@ | |||
| Using [NuGet lock files](https://docs.microsoft.com/nuget/consume-packages/package-references-in-project-files#locking-dependencies): | |||
|
|
|||
| ```yaml | |||
| - uses: actions/cache@v3 | |||
| - uses: actions/cache@v4 | |||
There was a problem hiding this comment.
|
This repo seems to be lacking maintenance attention. It may be helpful to make some noise on here https://github.com/orgs/community/discussions/121811 |
oliverklee
approved these changes
May 21, 2024
This was referenced May 23, 2024
joshmgross
reviewed
Jul 31, 2024
Co-authored-by: Josh Gross <joshmgross@github.com>
|
bump. At least run CI? Leaving this action like this seems very counter to the whole github actions push to update to node 20. |
|
Since #1323 (comment) has already been resolved and was an unrelated issue, I don't think we need these changes. Feel free to reopen if you feel otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested (not a js dev), but should not need any remarks else than:
Commit 1 may be one step forward to help to fix #1323, best wishes to remove all node16 deps.
But that does not explain why the GitHub annotation still talks that it is cache@v3 and not v4...
yargs also uses a 16.x.x number in package-lock.json, setup-python uses a 17.x.x version, maybe it and others need updating too