Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate save-always input #1452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshmgross
Copy link
Member

@joshmgross joshmgross commented Aug 14, 2024

Description

The save-always input added in v4 is not working as intended due to post-if expressions not supporting the input context.

To avoid breaking users who have already added this input to their workflows, it is being deprecated now and will be removed in the next major version (v5).

This also fixes our documentation for how to properly use the recommended alternative of a separate actions/cache/save step, which requires checking the cache-hit output to avoid attempting to save a cache that already exists.

Motivation and Context

How Has This Been Tested?

Validated that the input had a deprecation message: https://github.com/joshmgross/actions-testing/actions/runs/10395133356

Screenshots (if appropriate):

Deprecation message for save-always

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Since save-always is already broken, I do not consider this a breaking change.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The `save-always` input added in v4 is not
working as intended due to
`post-if` expressions not supporting the input
context.
To avoid breaking users who have already added
this input to their workflows, it is being
deprecated now and will be removed
in the next major version (v5).
See #1315 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants