Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for arm64 Windows #927

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Add support for arm64 Windows #927

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
026d4a4
add support for arm64 Windows
dmitry-shibanov Dec 20, 2023
e2ed1fe
revert 7z to exe
dmitry-shibanov Dec 20, 2023
1f96ccb
add comment
dmitry-shibanov Dec 21, 2023
1281125
Merge remote-tracking branch 'upstream/main' into v-dmshib/fix-arm64-…
aparnajyothi-y Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comment
  • Loading branch information
@dmitry-shibanov
dmitry-shibanov committed Dec 21, 2023
commit 1f96ccb994204a7a9e93b9592db4d174a2ffc4d4
5 changes: 5 additions & 0 deletions dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93199,6 +93199,11 @@ class BaseDistribution {
info = info || {}; // satisfy compiler, never null when reaches here
if (this.osPlat == 'win32') {
const extension = this.nodeInfo.arch === 'arm64' ? '.zip' : '.7z';
// Rename archive to add extension because after downloading
// archive does not contain extension type and it leads to some issues
// on Windows runners without PowerShell Core.
//
// For default PowerShell Windows it should contain extension type to unpack it.
if (extension === '.zip') {
const renamedArchive = `${downloadPath}.zip`;
fs_1.default.renameSync(downloadPath, renamedArchive);
Expand Down
5 changes: 5 additions & 0 deletions src/distributions/base-distribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,11 @@ export default abstract class BaseDistribution {
info = info || ({} as INodeVersionInfo); // satisfy compiler, never null when reaches here
if (this.osPlat == 'win32') {
const extension = this.nodeInfo.arch === 'arm64' ? '.zip' : '.7z';
// Rename archive to add extension because after downloading
// archive does not contain extension type and it leads to some issues
// on Windows runners without PowerShell Core.
//
// For default PowerShell Windows it should contain extension type to unpack it.
if (extension === '.zip') {
const renamedArchive = `${downloadPath}.zip`;
fs.renameSync(downloadPath, renamedArchive);
Expand Down
Loading