Skip to content

Commit

Permalink
Make sure we mask secrets when reporting telemetry. (#3315)
Browse files Browse the repository at this point in the history
  • Loading branch information
TingluoHuang authored Jun 4, 2024
1 parent 00888c1 commit edfdbb9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Runner.Common/JobServerQueue.cs
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ private async Task ProcessResultsUploadQueueAsync(bool runOnce = false)

private void SendResultsTelemetry(Exception ex)
{
var issue = new Issue() { Type = IssueType.Warning, Message = $"Caught exception with results. {ex.Message}" };
var issue = new Issue() { Type = IssueType.Warning, Message = $"Caught exception with results. {HostContext.SecretMasker.MaskSecrets(ex.Message)}" };
issue.Data[Constants.Runner.InternalTelemetryIssueDataKey] = Constants.Runner.ResultsUploadFailure;

var telemetryRecord = new TimelineRecord()
Expand Down

0 comments on commit edfdbb9

Please sign in to comment.