Listen directly to Broker for messages #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokesh755
reviewed
Mar 24, 2023
| } | ||
| else | ||
| { | ||
| // more aggressive backoff [30, 60] |
There was a problem hiding this comment.
Basically we'll retry forever in case of retriable exceptions?
Nit: Regarding comment, It's less aggressive right? since we're increasing the retry intervals.
There was a problem hiding this comment.
Yep I think so. This is copied behavior from the existing Message listener
There was a problem hiding this comment.
I guess it could be read as "more aggressively backing off by increasing the time" 😄
There was a problem hiding this comment.
I could have some maximum of continuousError where I abort if it reaches that
lokesh755
approved these changes
Mar 24, 2023
8 tasks
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 3 things:
/messageendpoint)We will set the
ServerUrlV2in a followup PR.