Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need to manually compile JS binary for hashFiles utility #2770

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Remove need to manually compile JS binary for hashFiles utility #2770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b134170
Add in pre-commit hook and husky integration to compile the js binary…
vanZeben Aug 15, 2023
f476301
Lint/format before build
vanZeben Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

cd src/Misc/expressionFunc/hashFiles

npx lint-staged
28 changes: 18 additions & 10 deletions src/Misc/expressionFunc/hashFiles/.prettierrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@

{
"printWidth": 80,
"tabWidth": 2,
"useTabs": false,
"semi": false,
"singleQuote": true,
"trailingComma": "none",
"bracketSpacing": false,
"arrowParens": "avoid",
"parser": "typescript"
}
"printWidth": 80,
"tabWidth": 2,
"useTabs": false,
"semi": false,
"singleQuote": true,
"trailingComma": "none",
"bracketSpacing": false,
"arrowParens": "avoid",
"overrides": [
{
"files": "*.{js,ts,json}",
"options": {
"tabWidth": 2
}
}
]
}
5 changes: 2 additions & 3 deletions src/Misc/expressionFunc/hashFiles/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
To compile this package (output will be stored in `Misc/layoutbin`) run `npm install && npm run all`.
To compile this package (output will be stored in `Misc/layoutbin`) run `npm install && npm run prepare && npm run all`.

> Note: this package also needs to be recompiled for dependabot PRs updating one of
> its dependencies.
When you commit changes to the JSON or Typescript file, the javascript binary will be automatically re-compiled and added to the latest commit.
Loading