-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create automated workflow that will auto-generate dotnet sdk patches #2776
Conversation
@@ -0,0 +1,167 @@ | |||
name: "DotNet SDK Upgrade" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure you test the workflow in a fork repo and it can create the PR properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just forced a re-run on it updating to latest, been testing this all out on a cloned repo here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments, thank you for putting this together 🙏
…ctions#2776) * Add in workflow to automatically generate dotnet SDK patches * Update workflow to move the creation of the PR until all the hashes have been compiled and added to the path * Update upgrade to run not in parallel to prevent git command overlaps * Update for tings feedback and do better user error handling * JSON spec doesn't have comments * Has to use the outputs to proxy variables between the runs * Wrong output variable * Be more explicit on the branch check * Fix comments and json output * Missed variable name in rename * Fix race condition on jq write * Update for comments and more optimized hash updates * Need to forcibly exit for state to be detected * Fixed the failure to use a variable instead
This workflow will automatically fetch the latest patch version for dotnet sdk and generate all the code changes we require in 1 PR without us having to do anything. This runs weekly on Monday, or at workflow dispatch.
An example run can be found here: https://github.com/bbq-beets/vanzeben-sandbox/actions/runs/5925891927
An example PR can be found here: https://github.com/bbq-beets/vanzeben-sandbox/pull/21