Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload the diagnostic logs to the Results Service #3114

Merged
merged 17 commits into from
Feb 1, 2024
Merged

Upload the diagnostic logs to the Results Service #3114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9b50273
upload diagnostic logs to results
jtamsut Jan 29, 2024
440e8aa
correct casing
jtamsut Jan 30, 2024
6811e1b
correct typo
jtamsut Jan 30, 2024
8aa0cb5
update contract
jtamsut Jan 30, 2024
479b701
update constant and define private method
jtamsut Jan 30, 2024
ddfae64
fix access
jtamsut Jan 30, 2024
6470492
fix reference to logs url
jtamsut Jan 30, 2024
d30b4c3
update
jtamsut Jan 30, 2024
4fc9ef7
use results func
jtamsut Jan 30, 2024
41c44a2
fix method naming
jtamsut Jan 30, 2024
93c8b07
rename to match rpc
jtamsut Jan 30, 2024
7a28c21
change API contract
jtamsut Jan 30, 2024
7bb10d8
fix lint issue
jtamsut Jan 30, 2024
c1adf17
refactor
jtamsut Jan 31, 2024
4895f44
remove unused method
jtamsut Feb 1, 2024
cce36c9
create new log type
jtamsut Feb 1, 2024
8b9f74e
Merge branch 'main' into jtamsut/upload-diagnostic-logs-to-results
jtamsut Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change API contract
  • Loading branch information
@jtamsut
jtamsut committed Jan 30, 2024
commit 7a28c2137626d2a0dd2613c667f59d62cbc8f607
2 changes: 1 addition & 1 deletion src/Sdk/WebApi/WebApi/Contracts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public class GetSignedDiagnosticLogsURLRequest
public class GetSignedDiagnosticLogsURLResponse
{
[DataMember]
public string DiagnosticLogsURL;
public string DiagLogsURL;
[DataMember]
public string BlobStorageType;
}
Expand Down
4 changes: 2 additions & 2 deletions src/Sdk/WebApi/WebApi/ResultsHttpClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,12 +451,12 @@ public async Task UploadResultsDiagnosticLogsAsync(string planId, string jobId,
{
// Get the upload url
var uploadUrlResponse = await GetDiagnosticLogsUploadUrlAsync(planId, jobId, cancellationToken);
if (uploadUrlResponse == null || uploadUrlResponse.DiagnosticLogsURL == null)
if (uploadUrlResponse == null || uploadUrlResponse.DiagLogsURL == null)
{
throw new Exception("Failed to get diagnostic logs upload url");
}

await UploadLogFile(file, true, true, uploadUrlResponse.DiagnosticLogsURL, uploadUrlResponse.BlobStorageType, cancellationToken);
await UploadLogFile(file, true, true, uploadUrlResponse.DiagLogsURL, uploadUrlResponse.BlobStorageType, cancellationToken);
}

private Step ConvertTimelineRecordToStep(TimelineRecord r)
Expand Down
Loading