feat: prompt environment in make:preload file #4187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a flag for that
RomainLanz
requested changes
Jul 5, 2023
Co-authored-by: Romain Lanz <2793951+RomainLanz@users.noreply.github.com>
Co-authored-by: Romain Lanz <2793951+RomainLanz@users.noreply.github.com>
|
Could we take the opportunity of a major version to rename the command so it contains "preload" instead of "prld"? This is so weird and I have never seen it abbreviated like that anywhere else. |
|
agree with that. i am always struggling to write it in abbreviated form |
|
Sure, let's rename it |
|
Should it be named |
|
Yeah, whatever sounds better to you guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node ace make:prldfilefor selecting environment