Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added drain func #1488

Merged
merged 2 commits into from
Oct 15, 2022
Merged

added drain func #1488

merged 2 commits into from
Oct 15, 2022

Conversation

nmehmedrnd
Copy link
Contributor

Basically adds function which waits till all currently running jobs finishes, for more graceful stop

@harisvsulaiman
Copy link
Member

@nmehmedrnd Would you mind adding some tests?

@nedyalkov
Copy link

Looks good to me, but it is indeed missing tests.

@nedyalkov nedyalkov mentioned this pull request Oct 10, 2022
Open
@harisvsulaiman
Copy link
Member

@nmehmedrnd Thank you for your contribution. 🚀🚀🚀

@harisvsulaiman harisvsulaiman merged commit 3d903a8 into agenda:master Oct 15, 2022
@koresar
Copy link
Contributor

koresar commented Oct 19, 2022

Published as v4.4.0. See History.md: https://github.com/agenda/agenda/blob/master/History.md

@simllll simllll mentioned this pull request Nov 8, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harisvsulaiman harisvsulaiman harisvsulaiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nmehmedrnd @harisvsulaiman @nedyalkov @koresar