Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat #1180: add StreamRouter.on_broker_shutdown hook #1182

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

Lancetnik
Copy link
Member

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Close #1180

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added the enhancement New feature or request label Jan 29, 2024
@davorrunje davorrunje added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit 4a4e618 Jan 30, 2024
30 checks passed
@davorrunje davorrunje deleted the feat-1180 branch January 30, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: FastAPI StreamRouter on_shutdown hook
2 participants