OS cruft removal #24
OS cruft removal #24
Conversation
There was a problem hiding this comment.
Thanks for the cleanup PR @Joshfindit. Do we need these file types in our .gitignore? I think removing the DS_Store files is a good idea.
|
@akdeb It's a good idea to keep .DS_Store in .gitignore as MacOS makes those files all the time. The other ones are less of a priority but I would suggest them as they help keep that cruft out of your repo when other people are submitting PRs with commits made on various systems |
|
@Joshfindit For the .gitignore, we'd want to keep it repo-specific and minimal. Broad OS/editor templates (Mac/Windows/Linux dumps, AFP shares, etc.) are overkill here and tend to bloat the file over time. OS/editor cruft should live in each dev’s global gitignore (git config --global core.excludesFile ~/.gitignore_global), not in the project’s ignore list. Project .gitignore should reflect artifacts produced by this repo (build output, env files, caches), not different OS files. I’m happy to merge a version that:
Let me know once you've made these updates and I will merge your PR to Elato. |
Removes the existing .DS_Store files and adds .gitignore entries to avoid them being added in future.
Also adds other undesirable OS files across MacOS, Windows, and Linux