refactoring: Cleanup dependencies, port indexer utils, delete dead code. #61
Conversation
| // MakeBlockDataFromValidatedBlock makes BlockData from agreement.ValidatedBlock | ||
| func MakeBlockDataFromValidatedBlock(input types.ValidatedBlock) BlockData { |
There was a problem hiding this comment.
These conversion functions were used during the Indexer refactoring and can be removed now.
| // getConfigFromDataDir Given the data directory, configuration filename and a list of types, see if | ||
| // a configuration file that matches was located there. If no configuration file was there then an | ||
| // empty string is returned. If more than one filetype was matched, an error is returned. | ||
| // Copied from Indexer util.GetConfigFromDataDir | ||
| func getConfigFromDataDir(dataDirectory string, configFilename string, configFileTypes []string) (string, error) { |
There was a problem hiding this comment.
Copied from Indexer util.GetConfigFromDataDir.
| // NameConfigPair is a generic structure used across plugin configuration ser/de | ||
| type NameConfigPair struct { |
There was a problem hiding this comment.
Move all these simple types to data to avoid circular dependencies.
@Eric-Warehime Thats strange, I wonder why the job passes. This is in the log:
|
@tzaffi I agree with most of this, and expect to make a couple more followup changes. In particular:
|
thx for clarifying |
Summary
Cleanup code prior to breaking out plugin dependencies:
Test Plan
N/A - non functional changes.