Skip to content

bugfix: indexer import types #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 15, 2023
Merged

bugfix: indexer import types #73

merged 6 commits into from
May 15, 2023

Conversation

tzaffi
Copy link
Contributor

@tzaffi tzaffi commented May 12, 2023 •
edited
Loading

Handle type update and pass indexer E2E tests

This PR results from fixing the type inconsistency for EvalDelta in go-algorand-sdk (algorand/go-algorand-sdk#531) and passing the failing nightly test in indexer.

NOTE:

This should not be merged until algorand/go-algorand-sdk#531 is merged and the go.mod in this project is updated.

@tzaffi tzaffi mentioned this pull request May 12, 2023
Closed
7 tasks
@codecov
Copy link

codecov bot commented May 12, 2023 •
edited
Loading

Codecov Report

Merging #73 (a414907) into master (442791a) will increase coverage by 1.39%.
The diff coverage is 74.38%.

❗ Current head a414907 differs from pull request most recent head 18edb86. Consider uploading reports for the commit 18edb86 to get more accurate results

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   67.66%   69.05%   +1.39%     
==========================================
  Files          32       36       +4     
  Lines        1976     2414     +438     
==========================================
+ Hits         1337     1667     +330     
- Misses        570      654      +84     
- Partials       69       93      +24
Impacted Files Coverage Δ
conduit/data/block_export_data.go 100.00% <ø> (+92.30%) ⬆️
conduit/plugins/importers/algod/metrics.go 100.00% <ø> (ø)
...plugins/processors/filterprocessor/gen/generate.go 34.28% <ø> (ø)
pkg/cli/internal/list/list.go 20.75% <ø> (ø)
...lugins/exporters/postgresql/postgresql_exporter.go 66.66% <51.21%> (-11.54%) ⬇️
pkg/cli/cli.go 65.97% <65.97%> (ø)
conduit/pipeline/pipeline.go 66.09% <72.10%> (+0.64%) ⬆️
conduit/data/config.go 76.47% <76.47%> (ø)
conduit/plugins/importers/algod/algod_importer.go 87.26% <87.82%> (-1.06%) ⬇️
conduit/pipeline/errors.go 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tzaffi
tzaffi commented May 15, 2023
View reviewed changes
tzaffi
tzaffi commented May 15, 2023
View reviewed changes
conduit/plugins/processors/filterprocessor/gen/generate.go
"txn.apap": true,
"txn.apsu": true,
"dt.lg": true,
"dt.sa": true,
Copy link
Contributor Author

@tzaffi tzaffi May 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot handle this slice type EvalDelta.SharedAccounts

@tzaffi tzaffi changed the title 23may indexer import types bugfix: 23may indexer import types May 15, 2023
@tzaffi tzaffi added the Bug-Fix PR proposing to fix a bug label May 15, 2023
@tzaffi tzaffi marked this pull request as ready for review May 15, 2023 00:39
@tzaffi tzaffi changed the title bugfix: 23may indexer import types bugfix: indexer import types May 15, 2023
@tzaffi tzaffi mentioned this pull request May 15, 2023
Merged
algochoi
algochoi reviewed May 15, 2023
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go after changing the Go SDK hash

@tzaffi tzaffi merged commit a6edc4d into master May 15, 2023
@tzaffi tzaffi deleted the 23may-indexer-import-types branch May 15, 2023 18:18
@tzaffi tzaffi mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiqizng shiqizng Awaiting requested review from shiqizng

2 more reviewers

@algochoi algochoi algochoi left review comments

@Eric-Warehime Eric-Warehime Eric-Warehime approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug-Fix PR proposing to fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzaffi @Eric-Warehime @algochoi