Skip to content

Build: Golang v20 upgrade/compatibility changes. #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2023
Merged

Build: Golang v20 upgrade/compatibility changes. #107

merged 1 commit into from
Jun 16, 2023

Conversation

gmalouf
Copy link
Contributor

@gmalouf gmalouf commented Jun 16, 2023

Summary

Golang v20 and compatibility changes.

Test Plan

Full build, unit, e2e tests pass.

@gmalouf gmalouf changed the title Golang v20 upgrade/compatibility changes. Build: Golang v20 upgrade/compatibility changes. Jun 16, 2023
@gmalouf gmalouf added the enhancement New feature or request label Jun 16, 2023
@gmalouf gmalouf marked this pull request as ready for review June 16, 2023 15:15
@gmalouf gmalouf requested a review from a team June 16, 2023 15:15
tzaffi
tzaffi approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winder winder merged commit 4e48617 into algorand:master Jun 16, 2023
@gmalouf gmalouf deleted the golang-v20-upgrade branch May 8, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@winder winder winder approved these changes

@tzaffi tzaffi tzaffi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmalouf @winder @tzaffi